generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 90
Wirej/aws sdk v3 amplify e2e tests #3349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
svidgen
merged 37 commits into
release-api-plugin-stable
from
wirej/aws-sdk-v3-amplify-e2e-tests
Oct 3, 2025
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
391c3b1
feat: migrate amplify-e2e-tests to AWS SDK v3
svidgen 8ce03b5
chore: update TODO and dependency licenses after amplify-e2e-tests mi…
svidgen 1d543aa
fix: resolve TypeScript build errors with transformer version compari…
svidgen d65764b
chore: update lock file, run prettier
svidgen adb38d7
fix: pin AWS SDK v3 versions to avoid node: import issues
svidgen 1406e82
chore: update license file
svidgen 5f60bc2
chore: update lock file
svidgen 4f79692
chore: note to Q on how to use e2e-* commands
svidgen d6a4f40
fix: repair cleanup script credential handling after AWS SDK v3 migra…
svidgen 6245798
chore: add logging to cleanup script to identify failure point
svidgen 7c2a96f
chore: add more debug logging to cleanup script arguments and filtering
svidgen dd81ab4
feat: complete AWS SDK v2 removal from cleanup script and e2e-core
svidgen 0169d49
feat: complete AWS SDK v2 removal from all amplify-e2e-tests files
svidgen 5cd11ff
chore: q upgrade aws-sdk in e2e-core as well
svidgen 611af4d
chore: q address lingering v2 usage
svidgen b79260a
fix: install Node.js 18 on Windows build to resolve eslint-plugin-jsd…
svidgen 4e2abf9
chore: force node 18 on windows build
svidgen d5c205b
chore: update windows build spec to match main, except node version
svidgen 59cb856
fix: use Node.js 18 on Windows build to resolve eslint-plugin-jsdoc c…
svidgen 9b02347
fix: use ignore-engines for Windows build instead of Node.js downgrade
svidgen b21bd13
revert: restore original Windows buildspec with Node.js 20.9.0
svidgen 7bad1e4
chore: fully revert node 18 fix
svidgen d738226
feat: enhance e2e log fetching to get complete logs with pagination
svidgen 00a555a
fix: use regionalized S3 client in predictions test to resolve Perman…
svidgen c0e0ffa
fix: handle ResourceNotFoundException properly in getDDBTable for AWS…
svidgen 5213a82
fix: remove duplicate imports and function declarations in prediction…
svidgen cb5edbd
fix: resolve S3 ACL and DynamoDB error handling issues
svidgen f815c4d
fix: update cleanup script error handling for AWS SDK v3
svidgen ef56f81
chore: update q todo to better reflect reality and timeline
svidgen 7850afe
chore: update q todo with brief executive summary
svidgen 45af4ec
fix(amplify-category-api-e2e-tests): aws sdk v3 error handling in cle…
svidgen 6421400
fix(amplify-category-api-e2e-core): aws sdk v3 dynamodb marshalling
svidgen 1ffc26a
chore: update dependency licenses for @aws-sdk/util-dynamodb
svidgen a6c2794
chore: regenerate yarn.lock after adding @aws-sdk/util-dynamodb depen…
svidgen 1500e31
fix(amplify-category-api-e2e-tests): aws sdk v3 s3 body reading
svidgen 4239ce9
Merge branch 'release-api-plugin-stable' into wirej/aws-sdk-v3-amplif…
svidgen 1f77e0f
chore: migrate e2e-test-manager to aws sdk v3
svidgen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # TASK-003: Amplify E2E Tests AWS SDK v3 Migration | ||
|
|
||
| ## Status: COMPLETED ✅ | ||
|
|
||
| ## Requirements | ||
|
|
||
| Migrate `packages/amplify-e2e-tests` from AWS SDK v2 to v3: | ||
|
|
||
| 1. ✅ Update package.json dependencies | ||
| 2. ✅ Migrate service imports and usage patterns | ||
| 3. ✅ Update test files and utilities | ||
| 4. ✅ Ensure all tests continue to pass | ||
|
|
||
| ## Services Migrated | ||
|
|
||
| - ✅ S3 (multiple files) | ||
| - ✅ IAM (matchers) | ||
| - ✅ STS (cleanup utilities) | ||
| - ✅ Organizations (cleanup utilities) | ||
| - ✅ CodeBuild (utilities) | ||
| - ✅ CognitoIdentityServiceProvider (multiple files) | ||
| - ✅ CloudFormation (cleanup utilities) | ||
| - ✅ Amplify (cleanup utilities) | ||
|
|
||
| ## Files Updated | ||
|
|
||
| - ✅ src/import-helpers/utilities.ts | ||
| - ✅ src/import-helpers/types.ts | ||
| - ✅ src/cleanup-e2e-resources.ts | ||
| - ✅ src/schema-api-directives/authHelper.ts | ||
| - ✅ src/cleanup-stale-test-buckets.ts | ||
| - ✅ src/aws-matchers/s3matcher.ts | ||
| - ✅ src/aws-matchers/iamMatcher.ts | ||
|
|
||
| ## Progress | ||
|
|
||
| - ✅ Analyze current AWS SDK usage patterns | ||
| - ✅ Update package.json dependencies | ||
| - ✅ Migrate service imports | ||
| - ✅ Update client instantiation patterns | ||
| - ✅ Update method calls (remove .promise()) | ||
| - ✅ Run tests to verify migration | ||
| - ✅ Commit changes | ||
|
|
||
| ## Notes | ||
|
|
||
| - Some files already used v3 (CognitoIdentityProviderClient in Lambda functions) | ||
| - Created compatibility layer for deleteS3Bucket function (e2e-core still uses v2) | ||
| - Updated OAuth flow types and other Cognito-related types | ||
| - All TypeScript compilation successful | ||
| - Migration patterns established for future packages | ||
|
|
||
| ## Dependencies Added | ||
|
|
||
| - @aws-sdk/client-cloudformation | ||
| - @aws-sdk/client-codebuild | ||
| - @aws-sdk/client-cognito-identity-provider | ||
| - @aws-sdk/client-iam | ||
| - @aws-sdk/client-organizations | ||
| - @aws-sdk/client-s3 | ||
| - @aws-sdk/client-sts | ||
| - @aws-sdk/client-amplify | ||
| - @aws-sdk/credential-providers | ||
|
|
||
| ## Compatibility Notes | ||
|
|
||
| - deleteS3Bucket function from amplify-category-api-e2e-core still expects v2 S3 client | ||
| - Created compatibility wrapper using aws-sdk v2 for this specific function | ||
| - This will need to be updated when e2e-core is migrated to v3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,6 @@ phases: | |
| commands: | ||
| - yarn run production-build | ||
| - yarn build-tests | ||
|
|
||
| artifacts: | ||
| files: | ||
| - 'shared-scripts.sh' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear to me whether this is intrinsic to the upgrade. Q did this while troubleshooting e2e failures, and I'm inclined to keep the change unless it's proven wrong.