chore: update deps to remove last bits of transitive aws-sdk v2 #3363

svidgen · 2025-11-06T22:47:20Z

Description of changes

Updates latest amplify core packages to latest to remove aws-cdk v2 transitive deps (Planned work)
Updates to node 20 to accommodate related bumped package node requirements (Unexpected work)
Updates for jest 30: snapshots to new format, assertion methods, timeouts (Unexpected work)

Updates node runtime to node 20 as part of the build/test scripts. We can explore an image update later if desired.

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Checklist

PR description included
yarn test passes
E2E test run linked
Tests are changed or added
Relevant documentation is changed or added (and PR referenced)
New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Updated eslint-plugin-jsdoc from ^40.1.0 to ^61.1.12 - Resolves Node.js 20 compatibility issue in build_linux e2e test - Latest version requires Node.js >=20.11.0 which supports our Node 20 requirement

- Add @aws-amplify/graphql-transformer dependency - Add @aws-amplify/graphql-transformer-core dependency - Add @aws-amplify/graphql-transformer-interfaces dependency - Add @aws-amplify/graphql-transformer-test-utils dependency These dependencies were imported in the AWS SDK v3 migration but never added to package.json, causing build failures in CI clean builds. Resolves build_linux failure: 'Cannot find module @aws-amplify/graphql-transformer'

- Remove aws-sdk v2 import from MultiAuthV2Transformer.e2e.test.ts - Remove aws-sdk v2 import from MultiAuthV2TransformerWithFF.e2e.test.ts - Remove credential clearing code that's no longer needed with SDK v3 - Fixes build-tests failure: 'Cannot find module aws-sdk'

…ormer tests - Replace aws-sdk v2 imports with mock AWS config objects in test files - Update AuroraDataAPIClient.test.ts to use mockAwsConfig instead of aws-sdk - Update AuroraServerlessMySQLDBReader.test.ts to use mockAwsConfig instead of aws-sdk - Fixes test failures: 'Cannot find module aws-sdk' in graphql-relational-schema-transformer

- Upgrade Jest from 26.6.2 to 30.2.0 for full node: import support - Update Jest environment and configuration for v30 compatibility - Remove velocity test exclusion - all tests now passing - Update snapshot for acm-resolver-auth test - Fix FixJestEnvironment for Jest 30 API changes Resolves AWS SDK v3 node: import compatibility issues that were preventing velocity tests from running.

- replace toThrowError() with toThrow() for jest 30 compatibility - fix yargs type issue in cleanup script - update testURL to testEnvironmentOptions in e2e config resolves typescript compilation errors in e2e test build

- fix toThrowError in graphql-transformers-e2e-tests - update testURL to testEnvironmentOptions in graphql transformers config ensures all e2e test packages build successfully with jest 30

- Add testTimeout: 2000000 to Jest configs in e2e test packages - Remove all jest.setTimeout() calls from 143 test files - Addresses systematic e2e test timeout failures with Jest 30

…st 30" This reverts commit efebfa9.

…ility - Fix TypeScript compilation errors in test files - jest.setTimeout calls are working correctly with Jest 30 - The real issue was incomplete toThrowError -> toThrow conversion

- Add --coverage=false to amplify-util-mock e2e scripts - Set collectCoverage: false in graphql-transformers-e2e-tests - Prevents broken pipe errors when coverage reporting is interrupted

This reverts commit caec8f0.

- Add npm rebuild to root postinstall to fix node-pty compilation - Addresses MODULE_NOT_FOUND error for node-pty native binaries in CI

- Update node-pty from 'beta' to '^1.0.0' for reliable prebuilt binaries - Remove postinstall rebuild script as stable version has prebuilt binaries - Fixes MODULE_NOT_FOUND error in CI environments

- Replace outdated raw GitHub URL with correct release download URL - Fixes 404 error preventing Node.js installation on Windows builds - Uses nvm-windows v1.2.2 release

- Update deprecated Jest matchers (toBeCalledWith → toHaveBeenCalledWith, etc.) - Update snapshots for Jest 30 format changes - All tests now passing with Jest 30

- replace deprecated jest.useFakeTimers('modern') with jest.useFakeTimers() - update snapshots for jest 30 format changes - all auth transformer tests now passing

- add npm rebuild step to fix node-pty module version mismatch - ensures native modules are compiled for correct node.js version in e2e environment

- replace nvm-windows installer with chocolatey nodejs installation - chocolatey is pre-installed and more reliable in codebuild windows environment - use specific node.js version 20.18.0 for consistency

- update jest-environment-node import to use default export for jest 30 - rebuild compiled javascript files - fixes 'Class extends value #<Object> is not a constructor' error

- update jest-circus/runner import to use default export for jest 30 - fixes 'circusRunner is not a function' error in e2e tests - rebuild compiled javascript files

- add proper regex patterns for axios imports - handle both direct axios imports and subpath imports - fixes 'Could not locate module axios' error in jest

- use absolute path to axios cjs file instead of relative mapping - removes regex patterns that may be causing jest resolution issues - should fix 'Could not locate module axios' error

- replace deprecated jest matchers (toBeCalledWith → toHaveBeenCalledWith, etc.) - fix ts-jest import issues (ts-jest/utils → @jest/globals) - update mocked usage to jest.Mocked<typeof T> pattern - update snapshots for jest 30 format changes - all unit tests now passing locally

- Update VTL snapshots to use unescaped quotes format - Fix Jest circus runner configuration in mock package - Address ES Modules compatibility issues

- Add missing FixJestCircusRunner.js for mock tests - Fix axios module mapping pattern in transformer e2e tests - Use proper regex pattern ^axios$ instead of plain string

- Add extensionsToTreatAsEsm and useESM configuration - Fixes 'You need to run with a version of node that supports ES Modules in the VM API' error - Required for Jest 30 compatibility with AWS SDK v3 dynamic imports

- Switch from ts-jest to ts-jest/presets/default-cjs - Use node test environment instead of custom environment - Remove ES modules configuration that causes dynamic import issues - Addresses Jest 30 compatibility with AWS SDK v3

The build failure was due to yarn registry 502 error, not Jest config. Reverting to investigate the ES modules issue with a different approach.

…eprecation - Move ts-jest config from globals to transform array to fix deprecation warning - Fix axios module mapping path to use absolute path to node_modules - Resolves Jest configuration error preventing e2e tests from running

- fix DynamoDB client credential configuration to prevent dynamic import errors - use credentials object format instead of individual accessKeyId/secretAccessKey - update configureDDBDataSource to handle both credential formats - fix ts-jest deprecation warning by moving config to transform array - resolves ES modules VM API errors in mock e2e tests

- update Object { to { format in e2e test snapshots - update Array [ to [ format in e2e test snapshots - resolves snapshot mismatch failures in e2e tests

- fix double-escaped quotes in api_3 test snapshot - resolves snapshot mismatch for 'updates AppSync API in headless mode 3' test - jest 30 changed quote escaping behavior in snapshots

- add null check for identityPoolId before calling deleteIdentityPool - add null check for userPoolId before calling deleteUserPool - prevents ValidationException when resource IDs are null during cleanup - resolves Auth V2 test failures in cleanup phase

- add testTimeout: 300000 (5 minutes) to jest config - resolves 'Exceeded timeout of 5000 ms for a hook' errors - auth v2 tests need more time for cognito resource setup/cleanup - jest 30 may have stricter default timeout behavior

- fix Array [ to [ format in resolvers.test.ts inline snapshots - fix Object { to { format in resolvers.test.ts inline snapshots - fix Array [ to [ format in populate-cfn-params.test.ts inline snapshot - resolves remaining snapshot mismatch failures in e2e tests

- fix 5 inline snapshots using old jest format (Array [, Object {) - update to new jest 30 format ([, {) - completes comprehensive snapshot format migration across all e2e packages

- Add jest.setTimeout(1000 * 60 * 30) to all Auth V2 exhaustive test files - Addresses timeout issues where tests exceed 5-minute limit during setup - Timeout set outside describe blocks per Jest 30 requirements

- Matches the fix used in _setupE2ETestsLinux function - Rebuilds native modules for current Node.js version - Resolves node-pty MODULE_VERSION mismatch in cleanup job

svidgen · 2025-11-12T15:13:21Z

✅ - E2E Tests
✅ - PR Checks

ShadowCat567

Overall looks good, just have some questions

ShadowCat567 · 2025-11-12T16:40:47Z

packages/amplify-dynamodb-simulator/__test__/index.test.js

  },
 }));

+jest.setTimeout(40 * 1000);


is this a Jest 30 thing where timeouts are put here instead of in before/beforeEach like in the previous implementation?

ShadowCat567 · 2025-11-12T16:48:44Z

...al-transformer/src/__tests__/__snapshots__/amplify-graphql-has-many-transformer.test.ts.snap

diff is too big to render, I am assuming the changes in here are similar to the other snapshot changes and it is fine

You can always look at it raw and ctrl+f for amplify-graphql-has-many-transformer.test.ts.snap.

Litany of things like this:

ShadowCat567 · 2025-11-12T16:51:27Z

...hql-transformer-migrator/src/__tests__/migration/__snapshots__/schema-inspector.test.ts.snap

where is this file coming from? This snapshot looks really odd

Oh, I didn't catch this change. Q decided to un-inline this snapshot:

I'm not sure this matters at all to me...

svidgen added 30 commits November 5, 2025 12:16

chore: initial package bump

e319a2b

fix: build errors

e3bf160

chore: add license changes

a9c5cb9

chore: update e2e test manager to not retry build failures

126ce24

chore: upgrade to node 20

a0d300b

fix: update eslint-plugin-jsdoc to support Node.js 20

ff4fe0a

- Updated eslint-plugin-jsdoc from ^40.1.0 to ^61.1.12 - Resolves Node.js 20 compatibility issue in build_linux e2e test - Latest version requires Node.js >=20.11.0 which supports our Node 20 requirement

chore: update license file

86d8418

fix: jest 30 compatibility for e2e tests

801741a

- replace toThrowError() with toThrow() for jest 30 compatibility - fix yargs type issue in cleanup script - update testURL to testEnvironmentOptions in e2e config resolves typescript compilation errors in e2e test build

fix: additional jest 30 compatibility fixes

2edb7d3

- fix toThrowError in graphql-transformers-e2e-tests - update testURL to testEnvironmentOptions in graphql transformers config ensures all e2e test packages build successfully with jest 30

fix: replace jest.setTimeout() with global testTimeout for jest 30

efebfa9

- Add testTimeout: 2000000 to Jest configs in e2e test packages - Remove all jest.setTimeout() calls from 143 test files - Addresses systematic e2e test timeout failures with Jest 30

Revert "fix: replace jest.setTimeout() with global testTimeout for je…

4112bae

…st 30" This reverts commit efebfa9.

fix: replace remaining toThrowError with toThrow for jest 30 compatib…

37c20f8

…ility - Fix TypeScript compilation errors in test files - jest.setTimeout calls are working correctly with Jest 30 - The real issue was incomplete toThrowError -> toThrow conversion

fix: disable coverage for e2e tests to prevent EPIPE errors

caec8f0

- Add --coverage=false to amplify-util-mock e2e scripts - Set collectCoverage: false in graphql-transformers-e2e-tests - Prevents broken pipe errors when coverage reporting is interrupted

Revert "fix: disable coverage for e2e tests to prevent EPIPE errors"

deeae73

This reverts commit caec8f0.

fix: add postinstall script to rebuild native modules

cdec04c

- Add npm rebuild to root postinstall to fix node-pty compilation - Addresses MODULE_NOT_FOUND error for node-pty native binaries in CI

fix: use stable node-pty version instead of beta

53439f2

- Update node-pty from 'beta' to '^1.0.0' for reliable prebuilt binaries - Remove postinstall rebuild script as stable version has prebuilt binaries - Fixes MODULE_NOT_FOUND error in CI environments

fix: update nvm-windows installation URL in Windows buildspec

7e4778c

- Replace outdated raw GitHub URL with correct release download URL - Fixes 404 error preventing Node.js installation on Windows builds - Uses nvm-windows v1.2.2 release

fix: update Jest 30 compatibility for name-mapping-transformer

af2d694

- Update deprecated Jest matchers (toBeCalledWith → toHaveBeenCalledWith, etc.) - Update snapshots for Jest 30 format changes - All tests now passing with Jest 30

fix: jest 30 compatibility for auth transformer

20e267a

- replace deprecated jest.useFakeTimers('modern') with jest.useFakeTimers() - update snapshots for jest 30 format changes - all auth transformer tests now passing

fix: rebuild native modules for e2e tests

b135088

- add npm rebuild step to fix node-pty module version mismatch - ensures native modules are compiled for correct node.js version in e2e environment

fix: windows build hanging on nvm installation

aa19a01

- replace nvm-windows installer with chocolatey nodejs installation - chocolatey is pre-installed and more reliable in codebuild windows environment - use specific node.js version 20.18.0 for consistency

fix: jest 30 environment compatibility for e2e tests

8b47cd3

- update jest-environment-node import to use default export for jest 30 - rebuild compiled javascript files - fixes 'Class extends value #<Object> is not a constructor' error

fix: jest 30 circus runner compatibility

5e5a31f

- update jest-circus/runner import to use default export for jest 30 - fixes 'circusRunner is not a function' error in e2e tests - rebuild compiled javascript files

fix: axios module mapping for jest in e2e tests

e2722b5

- add proper regex patterns for axios imports - handle both direct axios imports and subpath imports - fixes 'Could not locate module axios' error in jest

fix: simplify axios module mapping with absolute path

41bedd4

- use absolute path to axios cjs file instead of relative mapping - removes regex patterns that may be causing jest resolution issues - should fix 'Could not locate module axios' error

svidgen added 16 commits November 8, 2025 14:04

fix: update Jest snapshot headers for Jest 30 compatibility

f4d618c

fix: update Jest snapshots and mock config for Jest 30 compatibility

95fa6ad

- Update VTL snapshots to use unescaped quotes format - Fix Jest circus runner configuration in mock package - Address ES Modules compatibility issues

fix: complete Jest 30 compatibility fixes

06fa67c

- Add missing FixJestCircusRunner.js for mock tests - Fix axios module mapping pattern in transformer e2e tests - Use proper regex pattern ^axios$ instead of plain string

fix: add ES modules support to Jest config for mock tests

e6357a2

- Add extensionsToTreatAsEsm and useESM configuration - Fixes 'You need to run with a version of node that supports ES Modules in the VM API' error - Required for Jest 30 compatibility with AWS SDK v3 dynamic imports

revert: restore previous Jest configuration

b41b97f

The build failure was due to yarn registry 502 error, not Jest config. Reverting to investigate the ES modules issue with a different approach.

fix: update jest snapshots for jest 30 compatibility

3093c2d

- update Object { to { format in e2e test snapshots - update Array [ to [ format in e2e test snapshots - resolves snapshot mismatch failures in e2e tests

fix: correct quote escaping in jest snapshots for jest 30

124a96a

- fix double-escaped quotes in api_3 test snapshot - resolves snapshot mismatch for 'updates AppSync API in headless mode 3' test - jest 30 changed quote escaping behavior in snapshots

fix: increase jest test timeout for auth v2 e2e tests

168533b

- add testTimeout: 300000 (5 minutes) to jest config - resolves 'Exceeded timeout of 5000 ms for a hook' errors - auth v2 tests need more time for cognito resource setup/cleanup - jest 30 may have stricter default timeout behavior

fix: update remaining inline snapshots in MapsToTransformer e2e test

0c7fae5

- fix 5 inline snapshots using old jest format (Array [, Object {) - update to new jest 30 format ([, {) - completes comprehensive snapshot format migration across all e2e packages

feat: increase Jest timeout to 30 minutes for Auth V2 exhaustive tests

01937d1

- Add jest.setTimeout(1000 * 60 * 30) to all Auth V2 exhaustive test files - Addresses timeout issues where tests exceed 5-minute limit during setup - Timeout set outside describe blocks per Jest 30 requirements

fix: add npm rebuild to cleanup function for node-pty compatibility

7adbd71

- Matches the fix used in _setupE2ETestsLinux function - Rebuilds native modules for current Node.js version - Resolves node-pty MODULE_VERSION mismatch in cleanup job

svidgen marked this pull request as ready for review November 12, 2025 15:22

svidgen requested review from a team as code owners November 12, 2025 15:22

svidgen changed the title ~~Wirej/aws sdk v3 final~~ update deps to remove last bits of transitive aws-sdk v2 Nov 12, 2025

svidgen changed the title ~~update deps to remove last bits of transitive aws-sdk v2~~ chore: update deps to remove last bits of transitive aws-sdk v2 Nov 12, 2025

ShadowCat567 approved these changes Nov 12, 2025

View reviewed changes

svidgen merged commit c017d9d into release-api-plugin-stable Nov 12, 2025
7 checks passed

svidgen deleted the wirej/aws-sdk-v3-final branch November 12, 2025 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: update deps to remove last bits of transitive aws-sdk v2 #3363

chore: update deps to remove last bits of transitive aws-sdk v2 #3363

Uh oh!

svidgen commented Nov 6, 2025 •

edited

Loading

Uh oh!

svidgen commented Nov 12, 2025 •

edited

Loading

Uh oh!

ShadowCat567 left a comment

Uh oh!

ShadowCat567 Nov 12, 2025

Uh oh!

svidgen Nov 12, 2025

Uh oh!

ShadowCat567 Nov 12, 2025

Uh oh!

svidgen Nov 12, 2025

Uh oh!

svidgen Nov 12, 2025

Uh oh!

ShadowCat567 Nov 12, 2025

Uh oh!

svidgen Nov 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore: update deps to remove last bits of transitive aws-sdk v2 #3363

chore: update deps to remove last bits of transitive aws-sdk v2 #3363

Uh oh!

Conversation

svidgen commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Checklist

Uh oh!

svidgen commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShadowCat567 left a comment

Choose a reason for hiding this comment

Uh oh!

ShadowCat567 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

svidgen Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ShadowCat567 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

svidgen Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

svidgen Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ShadowCat567 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

svidgen Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

svidgen commented Nov 6, 2025 •

edited

Loading

svidgen commented Nov 12, 2025 •

edited

Loading