fix: ensure Status fields are populated! #181
Conversation
When we have adopt-or-create, the populated status was not getting patched to k8s. So, during the next reconcile, the controller attempts to recreate the resource. With this fix, we ensure that the controller does patch the resource with the adoption field!
|
/test s3-controller-test |
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test s3-controller-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #2459
Description of changes:
When we have adopt-or-create, the populated status was not
getting patched to k8s. So, during the next reconcile, the controller
attempts to recreate the resource.
With this fix, we ensure that the controller does patch the resource with
the adoption field!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.