Skip to content

✨ Custom Headers #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hanoj-budime
Copy link
Contributor

@hanoj-budime hanoj-budime commented Mar 6, 2025

  • Local: Build test ✔
image

Relations

Closes #601

@hanoj-budime
Copy link
Contributor Author

As I had a call with the AWS RUM team yesterday with Bosco Kingston, and Grace Lim, Grace mentioned that I should perform a local build test. I did so, and the build was successfully tested and worked fine as expected.

Please consider these changes as we discussed with the AWS team.

Bosco Kingston, and Grace Lim, if you're seeing this, please follow up. Thanks!

Copy link
Contributor

@limhjgrace limhjgrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The changes LGTM but I'd like to increase test coverage for this change since it's affecting all RUM events sent by the client.

  1. Can we ensure unit, integ, smoke test cover this change?
  2. Update docs in configuration.md re. this new configuration?

@limhjgrace limhjgrace requested a review from ps863 March 26, 2025 01:24
@hanoj-budime hanoj-budime requested a review from limhjgrace March 26, 2025 12:36
@ps863
Copy link
Member

ps863 commented Mar 26, 2025

issue: we need to add smoke test

@limhjgrace
Copy link
Contributor

limhjgrace commented Mar 27, 2025

issue: we need to add smoke test

Agreed. Updating smoke tests to cover this, most likely will have to be in a separate PR. Will update this PR once the one for the smoke tests are ready.

@limhjgrace
Copy link
Contributor

PR for smoke tests: #629

@limhjgrace limhjgrace merged commit 986fc17 into aws-observability:main Mar 27, 2025
3 checks passed
williazz pushed a commit to williazz/aws-rum-web that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Custom Request Headers for AWS RUM Web
3 participants