-
Notifications
You must be signed in to change notification settings - Fork 78
✨ Custom Headers #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Custom Headers #610
Conversation
As I had a call with the AWS RUM team yesterday with Bosco Kingston, and Grace Lim, Grace mentioned that I should perform a local build test. I did so, and the build was successfully tested and worked fine as expected. Please consider these changes as we discussed with the AWS team. Bosco Kingston, and Grace Lim, if you're seeing this, please follow up. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! The changes LGTM but I'd like to increase test coverage for this change since it's affecting all RUM events sent by the client.
- Can we ensure unit, integ, smoke test cover this change?
- Update docs in
configuration.md
re. this new configuration?
issue: we need to add smoke test |
Agreed. Updating smoke tests to cover this, most likely will have to be in a separate PR. Will update this PR once the one for the smoke tests are ready. |
PR for smoke tests: #629 |
Co-authored-by: Hanoj Budime <[email protected]>
Relations
Closes #601