Skip to content

Tech debt: Improve Metrics provider to make it more maintainable #2916

Closed
@leandrodamascena

Description

@leandrodamascena
Contributor

Why is this needed?

In the PR #2194 we refactored the Metrics utility to allow bring new utilities. But it created some technical debt that must be addressed now.

Some items we need to fix:

  • Cleanup the slight confusion in OOO / Protocol
    Fix possible mistakes in docstrings
    Remove old and commented code
    Refactor extract* into standalone functions to reduce call graph
    Split up functional and unit tests with new providers

Which area does this relate to?

Metrics

Suggestion

No response

Acknowledgment

  • Should this be considered in other Powertools for AWS Lambda languages? i.e. Java, TypeScript, and .NET

Activity

moved this from Triage to Working on it in Powertools for AWS Lambda (Python)on Aug 3, 2023
heitorlessa

heitorlessa commented on Aug 3, 2023

@heitorlessa
Contributor

adjusting labels to prevent incorrect metrics

changed the title [-]Tech debt: Fix the metrics utility to make the code clean and uniform.[/-] [+]Tech debt: Improve Metrics provider to make it more maintainable[/+] on Aug 3, 2023
github-actions

github-actions commented on Aug 9, 2023

@github-actions
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

4 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

tech-debtTechnical Debt tasks

Type

No type

Projects

Status

Shipped

Milestone

No milestone

Relationships

None yet

    Participants

    @heitorlessa@leandrodamascena

    Issue actions

      Tech debt: Improve Metrics provider to make it more maintainable · Issue #2916 · aws-powertools/powertools-lambda-python