-
Notifications
You must be signed in to change notification settings - Fork 434
feat(parser): Added Cognito trigger schemas #6737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VatsalGoel3
wants to merge
5
commits into
aws-powertools:develop
Choose a base branch
from
VatsalGoel3:feat/parser-cognito-schemas-fix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(parser): Added Cognito trigger schemas #6737
VatsalGoel3
wants to merge
5
commits into
aws-powertools:develop
from
VatsalGoel3:feat/parser-cognito-schemas-fix
+406
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
2 tasks
Loading status checks…
leandrodamascena
requested changes
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VatsalGoel3 can you pls run make format
and push a commit again? Ruff is complaining about some files.
Loading status checks…
Loading status checks…
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
feature
New feature or functionality
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #6203
Summary
Changes
This PR adds full support for all Amazon Cognito User Pool Lambda Triggers as part of the Parser (Pydantic) utility. These include schemas for:
Each schema includes:
__init__.py
User experience
Before:
@parser
for Cognito triggers.After:
@parser(model=CognitoXxxEventModel)
.Checklist
Is this a breaking change?
RFC issue number: N/A
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Some schemas are currently failing validation in tests due to discrepancies in the sample fixture files:
email_verified
,phone_number_verified
appear asbool
in test events but the schema expectsstr
awsSdk
vsawsSdkVersion
cause mismatchesWould you prefer:
bool | str
, with appropriate aliases?