link-all.sh not working as expected

[rantoniuk]

Describe the issue

I'm following the contribution guide:

• I cloned the repository
• ran the npx lerna run build --skip-nx-cache
• created a fresh CDK TS-based app
• and ran link-all.sh script

Even though I see the linking script to do symlinks, I still see:

$ npx cdk --version
2.1006.0 (build a3b9762)

instead of 0.0.0. When I tried to do:

$ rm -rf node_modules
$ npx cdk --version
Need to install the following packages:
cdk@2.1017.1
Ok to proceed? (y)

It seems like it's not seeing the locally built CDK version. I even went through my system, cleaned up stale aws-cdk versions but it didn't help. Anything obvious I am missing here?

Links

https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#linking

[ykethan]

Hey @rantoniuk, thank you for reaching out. This may be related to change #32775 and the contribution documentation may need to be updated to reflect these changes. I was able to observe this behavior as well.
But wanted to confirm are you experiencing any errors on deploy or synth?
For example, when running this link script i do observe the following with the modules linking to the local cdk clone and running npx cdk synth or npx cdk deploy did not throw an error.

alternatively, you can create a integration test file in the packages/@aws-cdk-testing/framework-integ/test/ folder to test your changes and would be similar to creating a sample app.
https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#verify-your-fix-by-deployment

Marking this as P2 documentation.