-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore(ec2): update PrefixList.fromLookup()
to expect the result from CcApi context provider has exactly one resource
#34199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hey @Tietew , this issue is now fixed in main repo with PR #34369, please take a look at the current failing tests for eks and redshift to proceed further. |
@shikha372 Thanks for fix! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@rix0rrr and @Tietew I have to revert this PR because the recent release of
|
…m CcApi context provider has exactly one resource (#34565) Re-creation of #34199 A jsii related issue #34199 (comment) should be fixed before merging this PR. ### Issue # (if applicable) Follow-up to #33619. ### Reason for this change CcApi context provider now can expect the matched count of resources: aws/aws-cdk-cli#251. `PrefixList.fromLookup()` is needed to be updated using this feature not to persist invalid results in `cdk.context.json`. See also aws/aws-cdk-cli#257. ### Description of changes - Bumped `@aws-cdk/cloud-assembly-schema` to latest ^44.1.0. - Specify `expectedMatchCount: 'exactly-one'` to expect exactly one prefix list id is returned. - Updated validation to check unexpected result. Actual error will be returned from the context provider. ### Describe any new or updated permissions being added N/A ### Description of how you validated changes Updated integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Issue # (if applicable)
Follow-up to #33619.
Reason for this change
CcApi context provider now can expect the matched count of resources: aws/aws-cdk-cli#251.
PrefixList.fromLookup()
is needed to be updated using this feature not to persist invalid results incdk.context.json
.See also aws/aws-cdk-cli#257.
Description of changes
@aws-cdk/cloud-assembly-schema
to latest ^43.6.0.expectedMatchCount: 'exactly-one'
to expect exactly one prefix list id is returned.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Updated integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license