feat(33270): support new bun lock file #34873
Merged
+32,261
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/medium
aws-cdk-automation
previously requested changes
Jul 1, 2025
2 tasks
|
Seems like a straightforward approach to me! |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
Hey @rix0rrr can I get a review here? |
alvazjor
reviewed
Sep 11, 2025
alvazjor
added
response-requested
alvazjor
approved these changes
Sep 12, 2025
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-community-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #33270
Reason for this change
NodejsFunction construct does not support bun with its new lock file name.
Description of changes
Addition of bun.lock to supported lock files while still maintaining lock.b usage.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Added unit tests for presence of bun.lock
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license