fix(sdk): preserve errorData across runInChildContext boundaries#525
Open
fix(sdk): preserve errorData across runInChildContext boundaries#525
Conversation
When `runInChildContext` re-wraps a replayed `DurableOperationError`, the handler did `new ChildContextError(originalError.message, originalError)` without forwarding `errorData`, so the typed payload disappeared after the second boundary crossing -- breaking error-classification flows that depend on it (operator-cancellation signals, failure categories, etc.). Forward `originalError.errorData` at both wrap sites (`run-in-child-context-handler.ts:224,435`). The wrapper now carries the payload in-memory and on the wire, all the way up the boundary stack. User-supplied `errorMapper` callbacks must forward `errorData` themselves if they want it preserved -- e.g. `errorMapper: (e) => new MyError(e.message, e, e.errorData)`. Fixes aws#524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
runInChildContextre-wraps a replayedDurableOperationError, the handler didnew ChildContextError(originalError.message, originalError)without forwardingerrorData, so the typed payload disappeared after the second boundary crossing -- breaking error-classification flows that depend on it (operator-cancellation signals, failure categories, etc.).Forward
originalError.errorDataat both wrap sites (run-in-child-context-handler.ts:224,435). The wrapper now carries the payload in-memory and on the wire, all the way up the boundary stack.User-supplied
errorMappercallbacks must forwarderrorDatathemselves if they want it preserved -- e.g.errorMapper: (e) => new MyError(e.message, e, e.errorData).Fixes #524
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.