Pass CMAKE_GENERATOR_PLATFORM to third-party build if set #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the underlying issue here is, per the CMake documentation:
https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2015%202017.html So currently the only way I can see to specify the target platform for the third-party build, at least when using the Visual Studio 2017 generator, is to specify |
|
Bump |
singku
approved these changes
Jul 19, 2019
|
This has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Specifically resolves an issue I encountered while building the SDK within a larger project.
May also help with #1087 (in combination with adding
-A x64to the CMake call creating the AWSSDK project in conan).Description of changes:
Pass the
CMAKE_GENERATOR_PLATFORMto theexecute_processcalls used to create cmake projects for thethird-partybuilds, if that parameter has been set. This fixes an issue I observed when setting the top-level generator toVisual Studio 15 2017(rather thanVisual Studio 15 2017 Win64), where the third-party modules were all built as 32-bit x86 objects, causing LNK2019 errors.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.