Make SsoCredentialsProvider builder usable #6178
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Only the
Builder
interface inSsoCredentialsProvider
is visible outside the package, theBuilderImpl
is protected.To make the builder for
SsoCredentialsProvider
usable outside the package, the interface has to be returned.Compare for example another
CredentialsProvider
build()
method where also the public interface is returned: StsAssumeRoleCredentialsProvider.javaModifications
Change the
builder()
method to return the public interface instead of the protected implementation.Testing
Current workaround is to cast the returned builder into the interface:
(SsoCredentialsProvider.Builder)SsoCredentialsProvider.builder()
Screenshots (if appropriate)
n/a
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License