Skip to content

Make SsoCredentialsProvider builder usable #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polarctos
Copy link

Motivation and Context

Only the Builder interface in SsoCredentialsProvider is visible outside the package, the BuilderImpl is protected.
To make the builder for SsoCredentialsProvider usable outside the package, the interface has to be returned.

Compare for example another CredentialsProvider build() method where also the public interface is returned: StsAssumeRoleCredentialsProvider.java

Modifications

Change the builder() method to return the public interface instead of the protected implementation.

Testing

Current workaround is to cast the returned builder into the interface:
(SsoCredentialsProvider.Builder)SsoCredentialsProvider.builder()

Screenshots (if appropriate)

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Only the `Builder` interface in `SsoCredentialsProvider` is visible outside the package, the `BuilderImpl` is protected. To make the builder for `SsoCredentialsProvider` usable outside the package the interface has to be returned.
@polarctos polarctos requested a review from a team as a code owner June 13, 2025 13:16
@polarctos
Copy link
Author

Original support for SsoCredentialsProvider was added in PR: #2118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant