Extend license check to .rs files #4428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This excludes the target directory (which isn't source code). We modify the number of lines checked for Copyright to 4, so that the bindgen-generated header in generated feature files doesn't push the license header out of the check window.
camshaft
approved these changes
Feb 19, 2024
dougch
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
n/a
Description of changes:
This excludes the target directory (which isn't source code). We modify the number of lines checked for Copyright to 4, so that the bindgen-generated header in generated feature files doesn't push the license header out of the check window.
Call-outs:
This only checks .rs files, not e.g. Cargo.toml. That seems reasonable to me, but happy to try extending it further; it would likely mean some filtering to avoid picking up the large amount of RFC toml files.
Testing:
Ran the checker successfully locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.