feature: support for ML-DSA handshake signatures #5303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #5257
Description of changes:
The last of the logic necessary to negotiate ML-DSA. I add the signature schemes, fix bugs in the auth selection logic that prevent ML-DSA from being chosen, and update TLS1.3 CertVerify to properly initialize the hash. After this PR, s2n-tls can handshake using ML-DSA.
Call-outs:
This PR is still trying to keep ML-DSA invisible to customers. There will be one last PR that makes it visible by adding documentation, updating "default_pq", adding integ tests, and adding a new value to the public s2n_tls_signature_algorithm enum. That's when we can consider ML-DSA done and announce it as available for use.
Testing:
New self-talk handshake tests.
Also, I manually tested a handshake against Openssl-3.5. Openssl command:
s2n-tls command and output:
Notice that the "None" signature negotiated is because ML-DSA hasn't been added to s2n_tls_signature_algorithm yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.