ci: workaround for nix + gnutls + ubuntu24 issue #5345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
@johubertj ran into an interesting issue where he couldn't run our integration tests even using Nix because GnuTLS flagged any priority string containing TLS1.0 or TLS1.1 as invalid. We traced the problem to the "etc/gnutls/config" file on his Ubuntu24 instance, which disabled TLS1.0 and TLS1.1. Nix wasn't overriding the config file when installing or running gnutls, so the system config file was used. See https://www.gnutls.org/manual/html_node/System_002dwide-configuration-of-the-library.html.
We should probably fix this in the upstream Nix repo, but we can work around the problem for now by setting the GNUTLS_SYSTEM_PRIORITY_FILE in our own Nix shell.
Testing:
I created an /etc/gnutls/config file on my EC2 instance:
GnuTLS run from
nix develop
then report no TLS1.0 support:After applying this fix, even with the config file still in place, GnuTLS started reporting TLS1.0 support again:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.