Skip to content

pom.xml missing references fix #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deki merged 3 commits into from
Jan 24, 2024
Merged

pom.xml missing references fix #750

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c15fb7e
pom.xml missing references fix
Jan 23, 2024
3e55e8e
Using version range
Jan 23, 2024
9481b71
revert maven shade downgrade
Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/springboot3/pet-store/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<dependency>
<groupId>com.amazonaws.serverless</groupId>
<artifactId>aws-serverless-java-container-springboot3</artifactId>
<version>[2.0-SNAPSHOT,)</version>
<version>2.0.0-M2</version>
</dependency>
</dependencies>

Expand All @@ -55,7 +55,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.5.1</version>
<version>3.5.0</version>
Copy link
Contributor

@deki deki Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to downgrade or were you facing any issues with the latest version?

Copy link
Contributor Author

@Neves97 Neves97 Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5.0 Was being marked as not found, so I downgraded to the suggested version.
Plugin 'org.apache.maven.plugins:maven-shade-plugin:3.5.1' not found

Copy link
Contributor Author

@Neves97 Neves97 Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build just fine though, but the warning does not go away.

Copy link
Contributor

@deki deki Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe related to your local cache? It's available in central: https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-shade-plugin/3.5.1/
Can you please remove the change from the PR? I will merge afterwards. Thanks.

<configuration>
<createDependencyReducedPom>false</createDependencyReducedPom>
</configuration>
Expand Down