Skip to content

Conversation

@deki
Copy link
Contributor

@deki deki commented May 7, 2024

Issue #, if available:
#758

Description of changes:
Did some testing with this app https://github.com/aws-samples/aws-lambda-java-workshop/tree/main/labs/unicorn-store/software/unicorn-store-spring and 512 MB memory.
Comparison between
old StreamLambdaHandler implementation: Duration: 648.79 ms Billed Duration: 649 ms Memory Size: 1024 MB Max Memory Used: 333 MB Init Duration: 9747.09 ms
and
new SpringDelegatingLambdaContainerHandler Duration: 16626.82 ms Billed Duration: 16627 ms Memory Size: 1024 MB Max Memory Used: 330 MB Init Duration: 1344.65 ms

With this change the init is done properly. Threading still needs to be removed from SCF.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@deki deki requested a review from olegz May 7, 2024 16:02
@maschnetwork
Copy link
Collaborator

LGTM

@olegz
Copy link
Collaborator

olegz commented May 15, 2024

LGTM as well

@deki deki merged commit 6d4210f into main May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants