Support prebuild on win/mac #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 57 57
Lines 5980 5980
=======================================
Hits 5037 5037
Misses 943 943 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
graebm
approved these changes
Mar 11, 2025
Co-authored-by: Michael Graeb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, and/or reason for changes (REQUIRED):
Description of changes:
Remove limitation that we cannot prebuild on mac/win.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.