Update EFA Node exporter dockerfile to latest procfs and node exporte…#887
Merged
Update EFA Node exporter dockerfile to latest procfs and node exporte…#887
Conversation
…r versions Signed-off-by: rpovelik <rpovelik@amazon.co.uk>
Contributor
|
please confirm whether container build has been tested with updated versions, and metrics are populating |
nghtm
reviewed
Oct 31, 2025
Contributor
nghtm
left a comment
nghtm
left a comment
There was a problem hiding this comment.
Awaiting confirmation of build testing and metrics
Contributor
Author
|
Hey @nghtm , I think I confirmed it in PR’s description already
Do you want to add a screenshot of metrics here? |
nghtm
approved these changes
Oct 31, 2025
Contributor
nghtm
left a comment
nghtm
left a comment
There was a problem hiding this comment.
sorry missed that - so we confirmed this container image builds with new procFS and node exporter versions. LGTM!
Contributor
|
please squash and merge |
Contributor
Confirming successful build on shared cluster and metrics are flowing (note did not run NCCL test)
|
KeitaW
pushed a commit
that referenced
this pull request
Feb 17, 2026
…r versions (#887) Signed-off-by: rpovelik <rpovelik@amazon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r versions
Description of changes: Update the docker file with the latest versions of procfs and node exporter dependencies.
Checked on team cluster with NCCL tests that the counters are increased and identical to rdma tool
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.