Skip to content

Conversation

@scottschreckengaust
Copy link
Member

This construct is to load data via LlamaIndex


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (c8ea823) to head (79071aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
+ Coverage   92.80%   93.14%   +0.34%     
==========================================
  Files          67       68       +1     
  Lines       17937    18436     +499     
  Branches      409      422      +13     
==========================================
+ Hits        16646    17172     +526     
+ Misses       1291     1264      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottschreckengaust scottschreckengaust force-pushed the feature/llama-index-data-loader branch from 3b1f36a to 089f224 Compare October 7, 2024 20:24
@krokoko krokoko self-requested a review October 14, 2024 17:34
krokoko
krokoko previously approved these changes Oct 14, 2024
Copy link
Contributor

@dineshSajwan dineshSajwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit picks

Signed-off-by: Scott Schreckengaust <[email protected]>
Signed-off-by: Scott Schreckengaust <[email protected]>
Signed-off-by: Scott Schreckengaust <[email protected]>
@krokoko krokoko self-requested a review October 15, 2024 16:42
Copy link
Contributor

@dineshSajwan dineshSajwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottschreckengaust scottschreckengaust merged commit c9e4623 into main Oct 15, 2024
@scottschreckengaust scottschreckengaust deleted the feature/llama-index-data-loader branch October 15, 2024 17:57
dineshSajwan pushed a commit that referenced this pull request Oct 17, 2024
* defaults for props
* add docker for llamaindex data loader
* set the platform to amd64
* add llamaindex architecture
* allow passing in a VPC
* add tests
* add enumeration to base class
* add headers

---------

Signed-off-by: github-actions <[email protected]>
Signed-off-by: Scott Schreckengaust <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Alain Krok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants