Add venv to shell prompt in dockerfiles #2857

SalmanMohammadi · 2025-07-02T14:32:48Z

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

Summary by CodeRabbit

Chores
- Updated environment naming conventions in Docker images for improved clarity.
- Ensured Conda environments are automatically activated in interactive shell sessions.
- Enhanced shell prompt to display the active Python virtual environment for better visibility during shell use.

coderabbitai · 2025-07-02T14:32:54Z

Walkthrough

The Dockerfiles for various base images were updated to rename the Conda environment to "axolotl-py${PYTHON_VERSION}" and ensure it is automatically activated in interactive bash sessions. Additionally, the shell prompt in the uv-base Dockerfile was customized to display the active virtual environment. No changes were made to exported or public code entities.

Changes

File(s)	Summary
docker/Dockerfile-base, docker/Dockerfile-base-next, docker/Dockerfile-base-nightly	Renamed Conda environment to "axolotl-py${PYTHON_VERSION}", updated PATH, added `conda init bash`, and ensured auto-activation via `.bashrc`.
docker/Dockerfile-uv-base	Appended command to `.bashrc` to customize shell prompt to show active virtual environment `(axolotl-venv)`.

Poem

In Docker's den where envs reside,
"Axolotl" now stands with Python pride.
Bash awakens, the env comes alive,
Prompts now sparkle, venvs thrive!
A bunny hops by, with a bashful grin—
"Your shell is ready, let coding begin!"
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8065fed and 26c7821.

📒 Files selected for processing (3)

docker/Dockerfile-base (1 hunks)
docker/Dockerfile-base-next (1 hunks)
docker/Dockerfile-base-nightly (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

docker/Dockerfile-base
docker/Dockerfile-base-nightly
docker/Dockerfile-base-next

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

winglian · 2025-07-02T14:54:30Z

What's the test plan for this?

SalmanMohammadi · 2025-07-02T15:05:53Z

What's the test plan for this?

I can build manually and make sure it works - how did you end up testing the uv image when you wrote it?

docker/Dockerfile-base

SalmanMohammadi · 2025-07-04T09:39:41Z

After rebuilding the image locally (just tested with dockerfile-base)

> docker run --rm -it axolotl-test bash
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

==========
== CUDA ==
==========

CUDA Version 12.4.1

Container image Copyright (c) 2016-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license

A copy of this license is made available in this container at /NGC-DL-CONTAINER-LICENSE for your convenience.

WARNING: The NVIDIA Driver was not detected.  GPU functionality will not be available.
   Use the NVIDIA Container Toolkit to start this container with GPU support; see
   https://docs.nvidia.com/datacenter/cloud-native/ .

(axolotl-py3.11) root@c3e32d3ac1b4:/workspace/axolotl# which python
/root/miniconda3/envs/axolotl-py3.11/bin/python
(axolotl-py3.11) root@c3e32d3ac1b4:/workspace/axolotl# which axolotl
/root/miniconda3/envs/axolotl-py3.11/bin/axolotl
(axolotl-py3.11) root@c3e32d3ac1b4:/workspace/axolotl# axolotl
[2025-07-04 09:39:07,087] [WARNING] [bitsandbytes.cextension.get_native_library:282] [PID:45] The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers and GPU quantization are unavailable.
Usage: axolotl [OPTIONS] COMMAND [ARGS]...

  Axolotl CLI - Train and fine-tune large language models

Options:
  --version  Show the version and exit.
  --help     Show this message and exit.

Commands:
  delinearize-llama4
  evaluate                    Evaluate a model.
  fetch                       Fetch example configs or other resources.
  inference                   Run inference with a trained model.
  lm-eval                     use lm eval to evaluate a trained language...
  merge-lora                  Merge trained LoRA adapters into a base model.
  merge-sharded-fsdp-weights  Merge sharded FSDP model weights.
  preprocess                  Preprocess datasets before training.
  quantize
  train                       Train or fine-tune a model.
  vllm-serve
(axolotl-py3.11) root@c3e32d3ac1b4:/workspace/axolotl#
[2025-07-04 09:39:07,087] [WARNING] [bitsandbytes.cextension.get_native_library:282] [PID:45] The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers and GPU quantization are unavailable.
Usage: axolotl [OPTIONS] COMMAND [ARGS]...

  Axolotl CLI - Train and fine-tune large language models

Options:
  --version  Show the version and exit.
  --help     Show this message and exit.

Commands:
  delinearize-llama4
  evaluate                    Evaluate a model.
  fetch                       Fetch example configs or other resources.
  inference                   Run inference with a trained model.
  lm-eval                     use lm eval to evaluate a trained language...
  merge-lora                  Merge trained LoRA adapters into a base model.
  merge-sharded-fsdp-weights  Merge sharded FSDP model weights.
  preprocess                  Preprocess datasets before training.
  quantize
  train                       Train or fine-tune a model

… print_venv

winglian · 2025-07-04T23:43:52Z

What's the test plan for this?

I can build manually and make sure it works - how did you end up testing the uv image when you wrote it?

Fired up a bare metal instance on Lambda to build and teat.

adding venv to prompt

8065fed

NanoCode012 reviewed Jul 3, 2025

View reviewed changes

docker/Dockerfile-base Outdated Show resolved Hide resolved

SalmanMohammadi requested a review from NanoCode012 July 4, 2025 09:39

SalmanMohammadi added 4 commits July 4, 2025 12:35

merging commands

26c7821

Merge branch 'main' into print_venv

5bbbd59

reverting

2b41bfe

Merge branch 'print_venv' of github.com:axolotl-ai-cloud/axolotl into…

d00bd99

… print_venv

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add venv to shell prompt in dockerfiles #2857

Add venv to shell prompt in dockerfiles #2857

Uh oh!

SalmanMohammadi commented Jul 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 2, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

winglian commented Jul 2, 2025

Uh oh!

SalmanMohammadi commented Jul 2, 2025

Uh oh!

Uh oh!

SalmanMohammadi commented Jul 4, 2025

Uh oh!

winglian commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Add venv to shell prompt in dockerfiles #2857

Are you sure you want to change the base?

Add venv to shell prompt in dockerfiles #2857

Uh oh!

Conversation

SalmanMohammadi commented Jul 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

winglian commented Jul 2, 2025

Uh oh!

SalmanMohammadi commented Jul 2, 2025

Uh oh!

Uh oh!

SalmanMohammadi commented Jul 4, 2025

Uh oh!

winglian commented Jul 4, 2025

Uh oh!

Uh oh!

SalmanMohammadi commented Jul 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)