aya-ebpf-macros: remove aya-ebpf version #1106
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
CI seems to disagree about it being unused 🤔 |
|
Oh, it's a dependency for doctests 🤦 that's why running clippy locally didn't catch it. |
|
@dave-tucker seems this issue is related: rust-lang/rust#58700 and one solution is to move documentation to the main crate from the macro crate. This is pretty inconvenient in our case because we write Line 30 in 3d8cb08 Maybe this bug should go upstream to https://github.com/Byron/cargo-smart-release? EDIT: filed GitoxideLabs/cargo-smart-release#33. |
| @@ -16,6 +16,3 @@ proc-macro2 = { workspace = true } | |||
| proc-macro-error = { workspace = true } | |||
| quote = { workspace = true } | |||
| syn = { workspace = true, default-features = true, features = ["full"] } | |||
|
|
|||
| [dev-dependencies] | |||
| aya-ebpf = { path = "../ebpf/aya-ebpf", version = "^0.1.1", default-features = false } | |||
There was a problem hiding this comment.
Remove the version = * field and the problems will go away. gitoxide also does this, and also went through the trouble with the version field.
The presence of this version specification causes cargo-smart-release to trip on the circular dependency. Fixes aya-rs#1050.
tamird
changed the title
The presence of this version specification causes cargo-smart-release to
trip on the circular dependency.
Fixes #1050.
This change is