fix: Update dependencies to latest versions and fix ESM compatibility #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade remark from v11.0.2 to v15.0.1 - Upgrade unist-util packages to latest versions - Upgrade meow from v5.0.0 to v13.2.0 - Remove promise.allsettled dependency (use native Promise.allSettled) Breaking changes addressed: - Convert require() to ESM imports in @power-doctest/markdown - Update CLI to use meow v13 API with importMeta - Fix type compatibility with new unist-util packages All tests pass after migration to ESM modules. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
azu
commented
Jul 7, 2025
| select.selectAll(`code[lang="javascript"]`, markdownAST), | ||
| ); | ||
| return codeBlocks.map((codeBlock: UnistNode & { value: string | undefined }) => { | ||
| const processor = remark(); |
Owner
Author
There was a problem hiding this comment.
We can move instancination to out of function.
Move the remark processor creation to module level to avoid creating a new instance on every function call, improving performance. Addresses review comment: #50 (comment) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Changes Addressed
Test Results
Migration Notes
The main challenge was adapting to the ESM-only ecosystem. Key changes:
createRequire()pattern with direct ESM imports🤖 Generated with Claude Code