Conversation
ghost
assigned
|
@petrosagg, status checks have failed for this PR. Please make appropriate changes and recommit. |
|
@petrosagg, status checks have failed for this PR. Please make appropriate changes and recommit. |
Switch from meta-nodejs to OpenEmbedded since it now officially maintained. Also updated the base system to rocko and bitbabke to 1.36 Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
|
@petrosagg, status checks have failed for this PR. Please make appropriate changes and recommit. |
Contributor
|
Superseded by #566 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for the supervisor to work correctly in IPv6 environments it needs to be RFC 3484 compliant. This RFC is implemented in the operating system and when a hostname resolution is done the results are returned to the application in the order of highest likelihood of succeeding.
NodeJS doesn't respect that order and re-sorts the records. Furthermore, it will only try the first entry and will not continue attempting the rest on failure.
To fix this we need to always pass the
verbatim: trueflag when resolving that was introduced in nodejs 8.5.0 and will become the default in the next major version. See nodejs/node#14731 and nodejs/node#17793