Skip to content

🐛 fix(nav): adjust overview links and popup #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirsch88 merged 4 commits into from
Dec 13, 2023
Merged

🐛 fix(nav): adjust overview links and popup #1242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
484eb7d
fix(nav): adjust overview links and popup
hirsch88 Dec 13, 2023
1263f3a
chore(): update base images
hirsch88 Dec 13, 2023
af36fd6
chore(): update base images
hirsch88 Dec 13, 2023
d956bb3
chore: trigger build
hirsch88 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-hairs-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/design-system-components': patch
---

Add missing `➞` sign to the overview links in the `bal-nav` component and adjust padding and height of the `bal-popup` component in fullscreen variant.
2 changes: 1 addition & 1 deletion packages/components/src/components/bal-nav/bal-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ export class NavMetaBar
target={this.activeMenuLinkItem?.overviewLink?.target}
onClick={() => this.linkItemClickListener(this.activeMenuLinkItem?.overviewLink)}
>
{this.activeMenuLinkItem?.overviewLink?.label}
{this.activeMenuLinkItem?.overviewLink?.label} ➞
</bal-nav-link>
{this.renderGridLinks(this.activeMenuLinkItem)}
</bal-nav-menu-flyout>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/bal-nav/components/overview-link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const OverviewLink: FunctionalComponent<OverviewLinkProps> = ({ item, isM
target={item.target}
onClick={ev => onClick(ev)}
>
{item.label}
{item.label} ➞
</a>
)
}
44 changes: 36 additions & 8 deletions packages/components/src/components/bal-nav/test/bal-nav.visual.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,34 @@
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
placeat modi suscipit laborum quisquam laudantium!
</p>
<p>
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
placeat modi suscipit laborum quisquam laudantium!
</p>
<p>
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
placeat modi suscipit laborum quisquam laudantium!
</p>
<p>
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
placeat modi suscipit laborum quisquam laudantium!
</p>
<p>
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
placeat modi suscipit laborum quisquam laudantium!
</p>
</bal-popup>

<bal-popup id="popup-login" label="Anmelden" content-width="440">
Expand Down Expand Up @@ -249,8 +277,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
active: true,
overviewLink: {
value: 'Privatkunden ➞',
label: 'Privatkunden ➞',
value: 'Privatkunden',
label: 'Privatkunden',
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
},
mainLinkItems: [
Expand Down Expand Up @@ -436,8 +464,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
},
],
overviewLink: {
value: 'Alle Versicherungslösungen ➞',
label: 'Alle Versicherungslösungen ➞',
value: 'Alle Versicherungslösungen',
label: 'Alle Versicherungslösungen',
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
},
},
Expand Down Expand Up @@ -640,8 +668,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
},
],
overviewLink: {
value: 'Alle Anlage- und Vorsorgelösungen ➞',
label: 'Alle Anlage- und Vorsorgelösungen ➞',
value: 'Alle Anlage- und Vorsorgelösungen',
label: 'Alle Anlage- und Vorsorgelösungen',
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
},
},
Expand Down Expand Up @@ -731,8 +759,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
},
],
overviewLink: {
value: 'Alle Bankprodukte ➞',
label: 'Alle Bankprodukte ➞',
value: 'Alle Bankprodukte',
label: 'Alle Bankprodukte',
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
},
},
Expand Down
7 changes: 4 additions & 3 deletions packages/components/src/components/bal-popup/bal-popup.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@
min-width: 100%
max-width: 100% !important
min-height: var(--bal-app-height, 100%)
padding-left: var(--bal-container-space)
padding-right: var(--bal-container-space)
.bal-popup__inner
padding-left: var(--bal-container-space)
padding-right: var(--bal-container-space)
&--variant-drawer
position: fixed
border-top-left-radius: var(--bal-popup-variant-drawer-radius)
Expand All @@ -51,7 +52,7 @@

.bal-popup__inner
overflow-y: auto
max-height: calc(var(--bal-app-height, 100%) - 8rem)
max-height: calc(var(--bal-app-height, 100%) - 4rem)

// Popup Head
// --------------------------------------------------
Expand Down