Skip to content

♿ a11y(list accordion): aria-label reads "open" / "close" #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirsch88 merged 4 commits into from
Feb 27, 2025
Merged

♿ a11y(list accordion): aria-label reads "open" / "close" #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c778369
Create PR for #1616
github-actions[bot] Feb 20, 2025
8b758d7
fix(list): a11y for label and title
hirsch88 Feb 20, 2025
e3a0c15
chore: increase default errorThreshold = 0.2
hirsch88 Feb 20, 2025
562e7d3
Merge branch 'main' into feat/issue-1616
hirsch88 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-seahorses-punch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**list**: make title and aria-label editable on accordion head and move open and close labels to the icon on the right side
15 changes: 5 additions & 10 deletions ...ore/src/components/bal-list/bal-list-item-accordion-head/bal-list-item-accordion-head.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,16 +153,6 @@ export class ListItemAccordionHead implements ComponentInterface, Loggable {
tabindex="0"
aria-expanded={ariaBooleanToString(this.accordionOpen)}
aria-controls={this.ariaState.controlId}
title={
this.accordionOpen
? i18nBalListItemAccordionHead[this.language].close
: i18nBalListItemAccordionHead[this.language].open
}
aria-label={
this.accordionOpen
? i18nBalListItemAccordionHead[this.language].close
: i18nBalListItemAccordionHead[this.language].open
}
onClick={this.onClick}
onKeyDown={this.onKeyDown}
>
Expand All @@ -173,6 +163,11 @@ export class ListItemAccordionHead implements ComponentInterface, Loggable {
name={this.icon}
size="small"
turn={this.accordionOpen}
title={
this.accordionOpen
? i18nBalListItemAccordionHead[this.language].close
: i18nBalListItemAccordionHead[this.language].open
}
></bal-icon>
</bal-list-item-icon>
</Host>
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/bal-list/test/bal-list-v2.visual.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<bal-list-item accordion>
<bal-list-item-accordion-head>
<bal-list-item-content>
<bal-list-item-title>Accordion List Item 2</bal-list-item-title>
<bal-list-item-title>Accordion List Item 2 Bubu</bal-list-item-title>
</bal-list-item-content>
</bal-list-item-accordion-head>
<bal-list-item-accordion-body class="bal-list__item__accordion-body__parent">
Expand Down