Skip to content

♿ a11y(tab-component): Keyboard interaction of tabs part 2 #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m4rc0z merged 3 commits into from
Apr 24, 2025
Merged

♿ a11y(tab-component): Keyboard interaction of tabs part 2 #1680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b1905c
Create PR for #1679
github-actions[bot] Apr 23, 2025
37a405a
a11y(bal-tabs): controlling navigation via keyboard through new property
mmarinkov Apr 23, 2025
d502809
format
mmarinkov Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-mangos-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': minor
---

**tabs**: new property handleAsTabList to control navigation via keyboard to use arrow or either tabulator
8 changes: 8 additions & 0 deletions packages/core/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3289,6 +3289,10 @@ export namespace Components {
* Find the options properties by its value
*/
"getOptionByValue": (value: string) => Promise<BalTabOption>;
/**
* If `true` then isTabList becomes true even if there is a link in the list.
*/
"handleAsTabList": boolean;
/**
* Defines the layout of the tabs.
*/
Expand Down Expand Up @@ -8442,6 +8446,10 @@ declare namespace LocalJSX {
* If `true` the tabs is a block element and uses 100% of the width
*/
"fullwidth"?: boolean;
/**
* If `true` then isTabList becomes true even if there is a link in the list.
*/
"handleAsTabList"?: boolean;
/**
* Defines the layout of the tabs.
*/
Expand Down
14 changes: 12 additions & 2 deletions packages/core/src/components/bal-tabs/bal-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ export class Tabs
*/
@Prop() dimInactiveElements = false

/**
* If `true` then isTabList becomes true even if there is a link in the list.
*/
@Prop() handleAsTabList = false

@Watch('value')
protected async valueChanged(newValue?: string, oldValue?: string) {
if (newValue !== oldValue) {
Expand Down Expand Up @@ -426,8 +431,12 @@ export class Tabs
return Array.from(this.el.querySelectorAll('.bal-tabs__nav__item'))
}

/**
* Tells if the component acts as a tab or link list.
* If only one link is in the list and handleAsTabList has been set to false it will be a link list
*/
private get isTabList(): boolean {
return this.store.filter(tab => !!tab.href).length === 0
return this.store.filter(tab => !!tab.href).length === 0 || this.handleAsTabList
}

private get items(): HTMLBalTabItemElement[] {
Expand Down Expand Up @@ -772,7 +781,8 @@ export class Tabs
}

async focus(tab: BalTabOption) {
const hasKeyboardFocus = this.el.querySelector<HTMLButtonElement>(`button.bal-focused`) !== null
const hasKeyboardFocus =
this.el.querySelector<HTMLButtonElement | HTMLAnchorElement>(`button.bal-focused, a.bal-focused`) !== null

if (this.swiper.isActive()) {
const options = await this.getOptions()
Expand Down