Skip to content

feat: Add windows arm64 python toolchains #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2025

Conversation

AustinSchuh
Copy link
Contributor

@AustinSchuh AustinSchuh commented Jul 6, 2025

The changelog for astral-sh/python-build-standalone release 20250630 says:

  • Add ARM64 Windows builds for Python 3.11+

Lets use them! This is helpful when using rules_python on arm64 windows

Work towards #2276

The changelog for astral-sh/python-build-standalone release 20250630
says:

  * Add ARM64 Windows builds for Python 3.11+

Lets use them!

Signed-off-by: Austin Schuh <[email protected]>
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, almost LGTM.

Please update "3.9" and "3.10" to use the same latest release. Usually they include security and other fixes, so a subset of versions from the release is not what we normally do.

And please change the existing changelog message about the toolchain bump. The users won't see 3.14.0b2 and the previous toolchain bump, so best to have one entry that they can read.

Update the version checksum script to output a format which is easy to
copy into versions.bzl
@AustinSchuh
Copy link
Contributor Author

Done! That's an easy and reasonable request.

I updated //python/private:print_toolchains_checksums to print the versions + checksums out in a format which can be copied into versions.bzl much easier. Happy to revert that if you'd rather not merge it.

@AustinSchuh AustinSchuh requested a review from aignas July 6, 2025 04:23
@aignas
Copy link
Collaborator

aignas commented Jul 6, 2025

Yes please, reverting the formatting would be easier because I have a PR for that ready.

@aignas aignas enabled auto-merge July 6, 2025 07:14
@aignas aignas added this pull request to the merge queue Jul 6, 2025
Merged via the queue into bazel-contrib:main with commit 29a7f6a Jul 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants