feat: freethreaded support for the builder API #3063
Draft
+745
−616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the configuration that we have for the `rules_python` and the defaults that we set for our users from the actual unit tests where we check that the extension is working correctly. With this we will be able to dog food the API and point users into the `MODULE.bazel` as the example snippet. Work towards bazel-contrib#2949 Work towards bazel-contrib#2747
Before it seems that we were relying on particular names in the pipstar platforms. This ensures that we rely on this less. Whilst at it fix a few typos and improve the formatting of the code. Work towards bazel-contrib#2949 Work towards bazel-contrib#2747
Before this we would pull all of the wheels that the user target configuration would be compatible with and that meant that it was not customizable. This also meant that there were a lot of footguns in the configuration where the select statements were not really foolproof. With this PR we select only those sources that need to be for the declared configurations. Freethreaded support should be done by defining extre freethreaded platforms using the new builder API. Work towards bazel-contrib#2747 Work towards bazel-contrib#2759 Work towards bazel-contrib#2849
aignas
force-pushed
the
exp/pypi-simplify-freethreaded
branch
from
ce4dd59 to
594f026
Compare
aignas
force-pushed
the
exp/pypi-simplify-freethreaded
branch
3 times, most recently
from
73c74d9 to
bc8424b
Compare
Stacked on bazel-contrib#3058 This is a continuation of bazel-contrib#3058 where we define freethreaded platforms. They need to be used only for particular python versions so I included an extra marker configuration attribute where we are using pipstar marker evaluation before using the platform. I think this in general will be a useful tool to configure only particular platforms for particular python versions Work towards bazel-contrib#2548, since this shows how we can define custom platforms Work towards bazel-contrib#2747 TODO: - [ ] Fix the remaining expectations in the unit tests. Maybe make the tests less brittle and define platforms for unit testing.
aignas
force-pushed
the
exp/pypi-simplify-freethreaded
branch
from
bc8424b to
5e66b5b
Compare
rickeylev
reviewed
Jul 6, 2025
| platforms[key] = struct( | ||
| env = env_, | ||
| tripple = "{}_{}_{}".format(abi, values.os_name, values.arch_name), |
| ], | ||
| env = {"platform_version": "0"}, | ||
| marker = "python_version ~= \"3.13\"" if freethreaded else "", |
There was a problem hiding this comment.
Pretty sure this should be >= 3.13
| platform_tags = [ | ||
| "macosx_*_{}".format(suffix) | ||
| for suffix in platform_tag_cpus | ||
| ], | ||
| want_abis = [ | ||
| "cp{0}{1}t", |
There was a problem hiding this comment.
nit: {0}{1} is fine for experimental api, but we should use named params for the final API. Please add a todo, at the least.
| requirements = requirements, | ||
| requirements = { | ||
| k: { | ||
| # TODO @aignas 2025-07-06: should we leave this as is? |
Comment on lines
+337
to
+338
| # TODO @aignas 2025-07-07: this should be solved in a better way | ||
| platforms[candidate].tripple.partition("_")[-1]: None |
There was a problem hiding this comment.
Yeah, isn't this problematic if platform names are user-chosen?
| @@ -406,21 +427,25 @@ def _configure(config, *, platform, os_name, arch_name, config_settings, env = { | |||
| # the lowest priority one needs to be the first one | |||
| platform_tags = ["any"] + platform_tags | |||
|
|
|||
| want_abis = want_abis or [ | |||
| "cp{0}{1}", | |||
| "abi3", | |||
There was a problem hiding this comment.
Why is abi3 here, but not in the MODULE config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #3058
This is a continuation of #3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.
I think this in general will be a useful tool to configure only
particular platforms for particular python versions
Work towards #2548, since this shows how we can define custom platforms
Work towards #2747