General UI Fixes / Updates

[jeznorth]

Overview

Links to Jira tickets

• BHBC-2303

Description of relevant changes

• General UI Fixes / Updates
• Numerous passes over the interface to ensure language, visual design and components are consistent.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1008-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1008-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1008

[codecov]

Codecov Report

Merging #1008 (6e9ff4a) into dev (0850ab6) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##              dev    #1008   +/-   ##
=======================================
  Coverage   68.06%   68.06%           
=======================================
  Files         378      378           
  Lines       11730    11727    -3     
  Branches     1990     1990           
=======================================
- Hits         7984     7982    -2     
+ Misses       3298     3297    -1     
  Partials      448      448           

Impacted Files	Coverage Δ
app/src/components/chips/SubmitStatusChip.tsx	16.66% <0.00%> (ø)
app/src/components/dialog/ComponentDialog.tsx	100.00% <ø> (ø)
app/src/components/publish/PublishDialogs.tsx	60.00% <ø> (ø)
...pp/src/components/publish/PublishProjectButton.tsx	9.67% <ø> (ø)
app/src/components/publish/PublishSurveyButton.tsx	38.77% <ø> (ø)
app/src/components/publish/SubmissionAlertBar.tsx	2.77% <0.00%> (-0.08%)	⬇️
.../src/features/projects/view/ProjectAttachments.tsx	66.66% <ø> (-4.31%)	⬇️
.../features/projects/view/ProjectAttachmentsList.tsx	56.75% <ø> (ø)
app/src/features/projects/view/ProjectHeader.tsx	4.87% <ø> (ø)
...ures/projects/view/components/LocationBoundary.tsx	4.54% <ø> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
15.8% Duplication

[KjartanE]

😹