Tech debt: Fixed linting errors and skipped tests #1063
Conversation
|
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1063 +/- ##
==========================================
- Coverage 67.55% 67.34% -0.22%
==========================================
Files 403 403
Lines 12570 12580 +10
Branches 2106 2105 -1
==========================================
- Hits 8492 8472 -20
- Misses 3538 3557 +19
- Partials 540 551 +11
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Openshift URLs for the PR Deployment: |
|
Found an issue: If you edit the map, and select a layer from the dropdown (nrm regional boundaries in my case), you get an infinite loop of requests to the openmaps service. I confirmed this is not the case in Dev. It looks like |
al-rosenthal
left a comment
al-rosenthal
left a comment
There was a problem hiding this comment.
ran this locally and it works as expected
🐇
|
@curtisupshall Maps seem happier after the latest changes from what I can tell. There is still 1 dependency error popping up though, in ProjectAdvancedFilters.tsx L91. I did give it a try locally, and adding the dependency (biohubApi.taxonomy) it is complaining about seems to work just fine (doesn't trigger any loops or anything). |
|
SonarCloud Quality Gate failed.
|
* Fixed linting errors * Removed some test skips * ignore-skip * Removed some snapshots * ran fix, removed comment * Updated hook dependencies * Added useMemo for debounce call * add useMemo dependency --------- Co-authored-by: Alfred Rosenthal <[email protected]> Co-authored-by: Nick Phura <[email protected]>
Fixes frontend linting errors and skipped tests.