TechDebt: useAxios 401/403 Request Retry #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… token has expired, but your refresh token is still valid.
|
Openshift URLs for the PR Deployment: |
NickPhura
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1079 +/- ##
==========================================
+ Coverage 64.31% 64.35% +0.03%
==========================================
Files 440 440
Lines 13501 13512 +11
Branches 2147 2151 +4
==========================================
+ Hits 8683 8695 +12
+ Misses 4288 4287 -1
Partials 530 530
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Openshift URLs for the PR Deployment: |
curtisupshall
approved these changes
Aug 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
KjartanE
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Add retry mechanic to useAxios to handle the case where your keycloak token has expired, but your refresh token is still valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
Add retry mechanic to useAxios to handle the case where your keycloak token has expired while working in the APP.
This can occur if you sit on an App page for longer than 5 minutes, without interacting with the api. In this case, the token will have quietly expired (5 minutes in Standard realm), and your next http request is guaranteed to fail.
Updated useAxios so that if the response fails, and the status is specifically a 401 or 403, then it attempts to refresh the token, and if it is successfully refreshed, re-run the last failed request.
Add useAxios tests.
Testing Notes
Let your token expire (wait 5 minutes), and then make some request (ie: save project, or similar), and you should see 2 requests get made, the first of which fails, and the second of which succeeds. The second call should also have a new/different bearer token in the headers.