SIMSBIOHUB-207/216: Survey Animals Table and Telemetry Device Deployment #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NoSummarySectionData.tsx
…tterbase from within SIMS api
…o critterbase calls, still need to implement automated signup
…pi routes similar to existing SIMS routes
…mponents can now be added to form on button click
… calling cb api through hooks in the frontend. No more extra auth headers, now all done through keycloak JWT.
…rbase. Made a wrapper function for critterbase selects that uses existing Formik components
…der and the docker compose that we don't need anymore
…ge in dev environment
JeremyQuartech
removed
the
Early Feedback Welcome
|
Openshift URLs for the PR Deployment: |
… device deployment form. This will now lookup information about the device id, and if one already exists in bctw, it will disallow changing the make or deploying on existing deployment times.
Contributor
curtisupshall
left a comment
curtisupshall
left a comment
There was a problem hiding this comment.
Code looks good! +1 for new CustomDataGrid 🙏 Most of my comments are about code style/formatting
api/src/paths/project/{projectId}/survey/{surveyId}/critters/index.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/critters/index.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/critters/{critterId}/deployments.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/deployments.ts
Outdated
Show resolved
Hide resolved
app/src/features/surveys/view/survey-animals/TelemetryDeviceForm.tsx
Outdated
Show resolved
Hide resolved
app/src/features/surveys/view/survey-animals/TelemetryDeviceForm.tsx
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
SIMSBIOHUB-207
SIMSBIOHUB-216
Description of Changes
Testing Notes