Skip to content

Conversation

@jeznorth
Copy link
Contributor

Links to Jira Tickets

  • SIMSBIOHUB-193

Description of Changes

  • Standardizing patterns for stratum and blocks components
  • Updating Participants component to conform with patter.

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1091 (6ba6194) into dev (1fa6146) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev    #1091   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files         487      487           
  Lines       14499    14499           
  Branches     2262     2262           
=======================================
  Hits         9331     9331           
  Misses       4578     4578           
  Partials      590      590           
Files Changed Coverage Δ
app/src/components/user/UserRoleSelector.tsx 10.00% <ø> (ø)
...eatures/surveys/components/SamplingMethodsForm.tsx 33.33% <ø> (ø)
...s/surveys/components/StratumCreateOrEditDialog.tsx 7.14% <ø> (ø)
...features/surveys/components/SurveyBlockSection.tsx 11.11% <ø> (ø)
...res/surveys/components/SurveySiteSelectionForm.tsx 11.53% <ø> (ø)
.../features/surveys/components/SurveyStratumForm.tsx 7.69% <0.00%> (ø)
...src/features/surveys/components/SurveyUserForm.tsx 4.34% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty 💅

curtisupshall
curtisupshall previously approved these changes Sep 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curtisupshall curtisupshall merged commit 11acde5 into dev Sep 13, 2023
@jeznorth jeznorth deleted the SIMSBIOHUB-193-UI-Cleanup branch September 14, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants