Skip to content

Conversation

@JeremyQuartech
Copy link
Contributor

@JeremyQuartech JeremyQuartech commented Sep 15, 2023

Links to Jira Tickets

Description of Changes

  • This PR adds all the supporting changes required to identify keyx files during a survey attachment, and send those files to BCTW.
  • Adds new /attachments/keyx/upload endpoint for keyx or zip files that handles BCTW transfers.
  • Adds 'uploadKeyx' method to BctwService.
  • Refined BctwService axios error-handling to support response time-out and connection refusal.
  • Adds 'Upload KeyX' option to survey uploads.
  • Customized file uploader for keyx files to display extended errors.

Testing Notes

  • It is working reliably at this stage, however the error handling could use refinement.

  • BCTW API requires a patch for this to function (will remove comment once this is live).

@JeremyQuartech JeremyQuartech added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Sep 15, 2023
@github-actions
Copy link

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #1095 (82daf76) into dev (79ef00f) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##              dev    #1095      +/-   ##
==========================================
+ Coverage   65.40%   65.44%   +0.03%     
==========================================
  Files         492      493       +1     
  Lines       14697    14801     +104     
  Branches     2302     2327      +25     
==========================================
+ Hits         9613     9686      +73     
- Misses       4448     4469      +21     
- Partials      636      646      +10     
Files Coverage Δ
...rveyId}/attachments/{attachmentId}/getSignedUrl.ts 96.66% <ø> (ø)
...ts/dialog/attachments/FileUploadWithMetaDialog.tsx 60.00% <ø> (ø)
app/src/components/file-upload/FileUpload.tsx 64.28% <ø> (ø)
api/src/utils/media/media-utils.ts 80.70% <80.00%> (+1.97%) ⬆️
.../src/components/attachments/FileUploadWithMeta.tsx 46.15% <33.33%> (+0.69%) ⬆️
app/src/hooks/api/useSurveyApi.ts 41.74% <20.00%> (-1.11%) ⬇️
app/src/components/file-upload/FileUploadItem.tsx 76.04% <44.44%> (-3.51%) ⬇️
...ctId}/survey/{surveyId}/attachments/keyx/upload.ts 87.23% <87.23%> (ø)
...pp/src/features/surveys/view/SurveyAttachments.tsx 59.37% <36.36%> (-7.30%) ⬇️
api/src/services/bctw-service.ts 79.01% <57.69%> (-6.96%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeremyQuartech JeremyQuartech marked this pull request as ready for review September 21, 2023 20:25
@github-actions
Copy link

@JeremyQuartech JeremyQuartech removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Sep 21, 2023
Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Just had some minor comments, none are urgent

@JeremyQuartech JeremyQuartech merged commit f23144b into dev Sep 25, 2023
@curtisupshall curtisupshall deleted the SIMSBIOHUB-263 branch September 25, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants