-
Notifications
You must be signed in to change notification settings - Fork 9
SIMSBIOHUB-263: Upload Keyx attachments to BCTW #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1095 +/- ##
==========================================
+ Coverage 65.40% 65.44% +0.03%
==========================================
Files 492 493 +1
Lines 14697 14801 +104
Branches 2302 2327 +25
==========================================
+ Hits 9613 9686 +73
- Misses 4448 4469 +21
- Partials 636 646 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
api/src/paths/project/{projectId}/survey/{surveyId}/attachments/process.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/attachments/process.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/attachments/upload.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/attachments/processKeyx.ts
Outdated
Show resolved
Hide resolved
api/src/paths/project/{projectId}/survey/{surveyId}/attachments/keyx/upload.ts
Outdated
Show resolved
Hide resolved
|
Openshift URLs for the PR Deployment: |
GrahamS-Quartech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
api/src/paths/project/{projectId}/survey/{surveyId}/attachments/keyx/upload.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
curtisupshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! Just had some minor comments, none are urgent








Links to Jira Tickets
Description of Changes
Testing Notes
It is working reliably at this stage,
however the error handling could use refinement.BCTW API requires a patch for this to function (will remove comment once this is live).