SIMSBIOHUB-308: Misc Bug Fixes #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1126 +/- ##
==========================================
- Coverage 63.10% 63.09% -0.01%
==========================================
Files 536 536
Lines 16326 16325 -1
Branches 2510 2510
==========================================
- Hits 10302 10301 -1
Misses 5333 5333
Partials 691 691
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
NickPhura
requested review from
AlfredRosenthal,
GrahamS-Quartech,
JeremyQuartech,
KjartanE,
MacDeluca and
curtisupshall
al-rosenthal
previously approved these changes
Oct 18, 2023
Contributor
al-rosenthal
left a comment
al-rosenthal
left a comment
There was a problem hiding this comment.
tested these changes in the pod and everything seems to be working 🐛
|
Kudos, SonarCloud Quality Gate passed!
|
JeremyQuartech
approved these changes
Oct 18, 2023
Contributor
JeremyQuartech
left a comment
JeremyQuartech
left a comment
There was a problem hiding this comment.
Everything working as expected for me. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
Bug fixes related to: https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-308
Description of Changes
Fix GCNotify (updated api keys and openshift secrets, etc)
Fix delete survey button (database function updated to account for some missed tables)
Updated Keycloak env vars for local and openshift builds (A few env vars were missing, and one was deprecated, just cleaned it up in general).
Testing Notes
Check that GCNotify works. ✔️
Check that deleting a survey works. ✔️
Check that anything related to keycloak, including service accounts and the api account, works. ✔️