Skip to content

Conversation

@KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Jan 15, 2024

Links to Jira Tickets

Description of Changes

  • Send artifacts to BioHub as part of the existing publish workflow.
  • The artifacts are to be sent as separate requests
  • When a survey has attached artifacts, those artifacts are submitted to biohub during publish

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Related PR for the BioHub changes: bcgov/biohubbc-platform#230

@github-actions
Copy link

- Select one or many records
- Bulk action to delete those records.
- Prevent deletion of records that are referenced by other data (e.g. Sampling site is referenced by an observation).
* bulk delete sample sites, select all
* pr edit, add indeterminate on checkbox
@codecov
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (c93d780) 57.80% compared to head (8771a3a) 57.29%.

Files Patch % Lines
api/src/services/platform-service.ts 27.77% 26 Missing ⚠️
api/src/models/biohub-create.ts 51.72% 14 Missing ⚠️
api/src/repositories/attachment-repository.ts 20.00% 4 Missing ⚠️
api/src/services/attachment-service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1193      +/-   ##
==========================================
- Coverage   57.80%   57.29%   -0.51%     
==========================================
  Files         591      590       -1     
  Lines       18082    17915     -167     
  Branches     2788     2772      -16     
==========================================
- Hits        10452    10265     -187     
- Misses       6942     6977      +35     
+ Partials      688      673      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curtisupshall
curtisupshall previously approved these changes Jan 16, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickPhura NickPhura added the Do Not Merge PR should not be merged label Jan 18, 2024
@NickPhura NickPhura added Ready For Review PR is ready for review and removed Do Not Merge PR should not be merged labels Jan 19, 2024
Remove delete artifact from biohub code (was causing regular sims artifact deletion to fail)
Add support for submitting description + comment to biohub.
curtisupshall
curtisupshall previously approved these changes Jan 22, 2024
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static read of the code looks good to me 📑

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and it works as expected! 🌮

@NickPhura NickPhura merged commit 000209e into dev Jan 23, 2024
@NickPhura NickPhura deleted the SIMSBIOHUB-432 branch January 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For Review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants