-
Notifications
You must be signed in to change notification settings - Fork 9
SIMSBIOHUB-424: Publish Documents to BioHub from SIMS #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Openshift URLs for the PR Deployment: |
- Select one or many records - Bulk action to delete those records. - Prevent deletion of records that are referenced by other data (e.g. Sampling site is referenced by an observation).
* bulk delete sample sites, select all * pr edit, add indeterminate on checkbox
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1193 +/- ##
==========================================
- Coverage 57.80% 57.29% -0.51%
==========================================
Files 591 590 -1
Lines 18082 17915 -167
Branches 2788 2772 -16
==========================================
- Hits 10452 10265 -187
- Misses 6942 6977 +35
+ Partials 688 673 -15 ☔ View full report in Codecov by Sentry. |
curtisupshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove delete artifact from biohub code (was causing regular sims artifact deletion to fail)
Add support for submitting description + comment to biohub.
curtisupshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static read of the code looks good to me 📑
|
curtisupshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
al-rosenthal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran this locally and it works as expected! 🌮



Links to Jira Tickets
Description of Changes
Testing Notes
Related PR for the BioHub changes: bcgov/biohubbc-platform#230