SIMSBIOHUB-453: Update Species Menus #1201

KjartanE · 2024-01-22T23:04:21Z

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-453

Description of Changes

Adjust species selector to follow similar style as select user.
Update components for front-end.
Requires possible update due to itis changes.

Testing Notes

{List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

github-actions · 2024-01-22T23:04:36Z

Openshift URLs for the PR Deployment:

codecov · 2024-01-22T23:06:50Z

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (66db344) 57.25% compared to head (e0fc577) 56.98%.

Files	Patch %	Lines
...ts/species/components/SpeciesAutocompleteField.tsx	2.77%	35 Missing ⚠️
...c/components/species/AncillarySpeciesComponent.tsx	5.55%	17 Missing ⚠️
...p/src/components/species/FocalSpeciesComponent.tsx	5.55%	17 Missing ⚠️
app/src/hooks/itis/useItisApi.ts	8.33%	11 Missing ⚠️
api/src/services/platform-service.ts	22.22%	7 Missing ⚠️
.../components/species/components/SelectedSpecies.tsx	16.66%	5 Missing ⚠️
...ponents/species/components/SpeciesSelectedCard.tsx	20.00%	4 Missing ⚠️
app/src/hooks/useContext.tsx	20.00%	4 Missing ⚠️
api/src/models/survey-view.ts	75.00%	0 Missing and 2 partials ⚠️
.../src/components/species/components/SpeciesCard.tsx	33.33%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1201      +/-   ##
==========================================
- Coverage   57.25%   56.98%   -0.28%     
==========================================
  Files         586      594       +8     
  Lines       17877    17983     +106     
  Branches     2745     2768      +23     
==========================================
+ Hits        10235    10247      +12     
- Misses       6978     7070      +92     
- Partials      664      666       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-25T23:23:12Z

Openshift URLs for the PR Deployment:

api/src/models/survey-view.ts

api/src/paths/project/{projectId}/survey/{surveyId}/update/get.ts

api/src/paths/taxonomy/itis/search.ts

api/src/services/es-service.ts

app/src/hooks/api/useTaxonomyApi.ts

docker-compose.yml

app/src/components/species/components/SpeciesSelectedCard.tsx

NickPhura · 2024-01-29T17:56:44Z

@KjartanE
Make sure to add any env vars to the env.docker (as well as the docker-compose and .pipeline config file)

Also as we discussed, we can just call SOLR directly from the frontend, rather than proxying it through the API. Nothing about the SOLR endpoint, thankfully, is private or protected.

env_config/env.docker

…to SIMSBIOHUB-453

…rations and Telemetry (#1198) * Add support for hiding/showing table columns for Obserations and Telemetry * Added sessionStorage call in order to cache column visibility across app reloads * Renamed ObservationComponent and ManualTelemetryComponent to ObservationsTableContainer and ManualTelemetryTableContainer, respectively

* Adding PageHeader component to all relevant pages * Small Layout Fix * Fixing test * Remove uuid call from SkeletonLoaders.tsx * Lint fixes. * ignore-skip --------- Co-authored-by: Curtis Upshall <[email protected]> Co-authored-by: Nick Phura <[email protected]>

…nimals (#1202) * Combined the Telemetry and Observations map/table view on the Survey page, allowing users to toggle between them; * Added server-side support for paginating the observations fetching endpoint; * Modified the Manage Observations page to use server-side pagination; * Added a new endpoint to fetch all the spatial data relating to survey observations; * Deleted some old code related to Survey Summary Results.

api/src/services/survey-service.ts

app/src/components/species/components/SpeciesSelectedCard.tsx

sonarqubecloud · 2024-02-02T19:19:27Z

Quality Gate failed

Failed conditions

1 Security Hotspot
5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

curtisupshall

Code looks good to me!

KjartanE and others added 2 commits January 18, 2024 17:29

species auto complete components created

965c7ee

Merge branch 'dev' into SIMSBIOHUB-453

ff32213

itis search api endpoint and service functions

0260d49

NickPhura changed the title ~~SIMSBIOHUB-453: Add Attributes to Species Observations~~ SIMSBIOHUB-453: Update Species Menus Jan 24, 2024

KjartanE and others added 3 commits January 24, 2024 17:22

clean up components, spoof data for itis names

590c183

fix update tests

007eddf

Merge branch 'dev' into SIMSBIOHUB-453

9b4597f

KjartanE marked this pull request as ready for review January 25, 2024 23:23

KjartanE added the Ready For Review PR is ready for review label Jan 25, 2024

curtisupshall reviewed Jan 26, 2024

View reviewed changes

NickPhura requested review from MacDeluca, NickPhura and al-rosenthal January 29, 2024 17:57

KjartanE and others added 4 commits January 29, 2024 10:58

species itis search moved to FE, axios get WIP

03ef421

clean up itis api use file

95dc036

Minor cleanup

a2fc96e

Update env vars

d8d072b

curtisupshall reviewed Jan 31, 2024

View reviewed changes

env_config/env.docker Outdated Show resolved Hide resolved

env_config/env.docker Show resolved Hide resolved

KjartanE and others added 8 commits January 31, 2024 15:09

update tsn object, search by tsn functioning

61b8019

Fix sims frontend -> biohub backend taxon calls

784324e

clean up request functions

41aa9f3

Update itis search to support array of terms

9b1900b

Merge branch 'SIMSBIOHUB-453' of https://github.com/bcgov/biohubbc in…

578a25c

…to SIMSBIOHUB-453

Update search control to show no options if search returns empty array

bb46cd4

Add todo

a5d6b44

clean up

1023906

curtisupshall and others added 9 commits February 1, 2024 14:29

UI Updates (#1205)

db47ec8

* Adding PageHeader component to all relevant pages * Small Layout Fix * Fixing test * Remove uuid call from SkeletonLoaders.tsx * Lint fixes. * ignore-skip --------- Co-authored-by: Curtis Upshall <[email protected]> Co-authored-by: Nick Phura <[email protected]>

Merge branch 'dev' into SIMSBIOHUB-453

26ce397

remove unused functions and tests

ce6b26a

add new envs to pipeline

f677877

fix tsn path

f6278f5

switch from label to commonName prop

b2218ea

fix test

fd500c7

curtisupshall reviewed Feb 2, 2024

View reviewed changes

api/src/services/survey-service.ts Outdated Show resolved Hide resolved

api/src/services/survey-service.ts Outdated Show resolved Hide resolved

app/src/components/species/components/SpeciesSelectedCard.tsx Outdated Show resolved Hide resolved

pr edits

e0fc577

curtisupshall approved these changes Feb 3, 2024

View reviewed changes

NickPhura approved these changes Feb 5, 2024

View reviewed changes

KjartanE merged commit 6118b56 into dev Feb 5, 2024

KjartanE deleted the SIMSBIOHUB-453 branch February 5, 2024 17:57

SIMSBIOHUB-453: Update Species Menus #1201

SIMSBIOHUB-453: Update Species Menus #1201

Uh oh!

Conversation

KjartanE commented Jan 22, 2024

Links to Jira Tickets

Description of Changes

Testing Notes

Uh oh!

github-actions bot commented Jan 22, 2024

Uh oh!

codecov bot commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NickPhura commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 2, 2024

Quality Gate failed

Uh oh!

curtisupshall left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jan 22, 2024 •

edited

Loading

NickPhura commented Jan 29, 2024 •

edited

Loading