SIMSBIOHUB-544: Update project/survey start/end date constraints #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vey dates being between project dates. Update associated yup schema.
NickPhura
requested review from
KjartanE,
MacDeluca,
al-rosenthal,
curtisupshall and
mauberti-bc
|
Openshift URLs for the PR Deployment: |
NickPhura
commented
Mar 15, 2024
NickPhura
commented
Mar 15, 2024
Contributor
al-rosenthal
left a comment
al-rosenthal
left a comment
There was a problem hiding this comment.
the new trigger works but I noticed that the survey end date component is still warning that End Date cannot come after the Project End Date
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1245 +/- ##
==========================================
+ Coverage 54.56% 54.57% +0.01%
==========================================
Files 599 599
Lines 18392 18387 -5
Branches 2837 2832 -5
==========================================
Hits 10035 10035
+ Misses 7703 7698 -5
Partials 654 654 ☔ View full report in Codecov by Sentry. |
mauberti-bc
approved these changes
Mar 15, 2024
Collaborator
mauberti-bc
left a comment
mauberti-bc
left a comment
There was a problem hiding this comment.
Created Projects and Surveys with non-overlapping dates 👍
curtisupshall
approved these changes
Mar 15, 2024
Contributor
curtisupshall
left a comment
curtisupshall
left a comment
There was a problem hiding this comment.
Code looks good to me
|
Please retry analysis of this Pull-Request directly on SonarCloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update associated yup schema.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-544
Description of Changes
Update project and survey date triggers to remove restrictions on survey dates being between project dates.
Update associated yup schema.
Why? The triggers were not complete (there were cases they didn't handle correctly) + the project dates are going to be deprecated in future. So this resolves the trigger issue (by removing the constraints altogether), and moves a few steps closer to the eventual goal of removing the project dates.
Testing Notes
Project start date must always come before its own end date, as before.
Survey start date must always come before its own end date, as before, but now has no constraints related to the project dates. So a survey could start before a project, or start after the project has ended, etc.