BHBC-2092

[cgarrettjones]

Overview

• removing template configuration from database migration

Note: this branch is based off of a PR that removed security label DB objects.

Links to Jira tickets

• BHBC-2092

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

The following SQL must be run in target promotional environment before applying this release:

delete from public.migration where name in (
  '20221206121332_update_summary_template_species.ts',
  '20221105123456_update_templates_ids.ts',
  '20221018121332_add_summary_template_species.ts',
  '20221018121331_add_summary_templates.ts',
  '20221005142000_deer_aerial_non_srb_templates.ts',
  '20220916142000_elk_srb_non_srb_templates.ts',
  '20220909191230_update_elk_trasect_and_distance_sampling_validation_schemas.ts',
  '20220901133100_update_survey_validation_schemas.ts',
  '20220301093900_update_sheep_validation_transformation.ts',
  '20220228103100_update_goat_template_schemas.ts',
  '20220224160300_update_moose_template_schemas.ts',
  '20211216095022_update_moose_template_schemas.ts',
  '20211206121200_update_transformation_schema.ts',
  '20211202093900_insert_sheep_validation_transformation.ts',
  '20211201093900_insert_goat_validation_transformation.ts',
  '20211126135830_update_transformation_validation_schema.ts',
  '20211020095230_update_validation_schemas.ts',
  '20211015106029_transformation_schemas_2.ts',
  '20211015105029_validation_schemas_2.ts',
  '20210927010804_transformation_schema.ts',
  '20210909000000_validation_schemas.ts',
  '20221210145800_SIMS.1.4.0.ts'
);

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-891-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-891-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=891

[codecov]

Codecov Report

Merging #891 (098d49a) into dev (2693d63) will increase coverage by 2.45%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #891      +/-   ##
==========================================
+ Coverage   62.20%   64.65%   +2.45%     
==========================================
  Files         380      364      -16     
  Lines       12287    11655     -632     
  Branches     2183     2097      -86     
==========================================
- Hits         7643     7536     -107     
+ Misses       4250     3727     -523     
+ Partials      394      392       -2     

Impacted Files	Coverage Δ
api/src/models/project-survey-attachments.ts	44.44% <ø> (+7.48%)	⬆️
api/src/models/survey-view.ts	100.00% <ø> (ø)
.../src/paths/project/{projectId}/attachments/list.ts	46.66% <0.00%> (-50.00%)	⬇️
...t/{projectId}/attachments/{attachmentId}/delete.ts	0.00% <ø> (ø)
...jectId}/attachments/{attachmentId}/metadata/get.ts	96.66% <ø> (-0.56%)	⬇️
.../{projectId}/survey/{surveyId}/attachments/list.ts	0.00% <0.00%> (ø)
...ey/{surveyId}/attachments/{attachmentId}/delete.ts	0.00% <ø> (ø)
...rveyId}/attachments/{attachmentId}/metadata/get.ts	34.37% <ø> (+2.79%)	⬆️
api/src/repositories/attachment-repository.ts	18.18% <ø> (+5.37%)	⬆️
api/src/services/attachment-service.ts	16.27% <ø> (+7.84%)	⬆️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[NickPhura]

@cgarrettjones

Looks like the formatter is failing.

Could also remove the Dashboard page from the APP as well, and any related code, as I think it is no longer needed? Was meant to show projects with pending security reviews I believe.

[cgarrettjones]

removal of Dashboard being pushed in #896.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
4.5% Duplication

[KjartanE]

☃️