Skip to content

Conversation

@NickPhura
Copy link
Contributor

Overview

Links to Jira tickets

  • {List all applicable Jira tickets}

Description of relevant changes

  • Update spatial transform seed (copy similar changes from biohub seed)

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #972 (9773d7c) into dev (faae742) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #972   +/-   ##
=======================================
  Coverage   66.70%   66.70%           
=======================================
  Files         358      358           
  Lines       11642    11642           
  Branches     2009     2009           
=======================================
  Hits         7766     7766           
  Misses       3465     3465           
  Partials      411      411           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚔️

@NickPhura NickPhura merged commit a1b7f83 into dev Mar 15, 2023
@NickPhura NickPhura deleted the BugFix_Spatial_Transform_Seed branch March 15, 2023 16:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants