Skip to content

fix node 18 support by downgrading glob to v10 #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

weiwei
Copy link

@weiwei weiwei commented Feb 8, 2025

Description

  • Source branch in your fork has meaningful name (not main)

Fixes Issue:
#2349 glob dropped node < 20 support in version 11. js-beautify promises wider Node version range so here it is downgraded to the last one that supports node 18.

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

@bitwiseman bitwiseman added this to the v1.15.3 (next release) milestone Feb 10, 2025
@bitwiseman bitwiseman added type: bug implementation: javascript dependencies Pull requests that update a dependency file labels Feb 10, 2025
@bitwiseman bitwiseman merged commit dc9880b into beautifier:main Feb 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file implementation: javascript type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants