default for bonsai-limit-trie-logs-enabled=True

[macfarla]

change default (currently false) for

bonsai-limit-trie-logs-enabled=True

[macfarla]

this change breaks the minimalist-staker profile with the message --bonsai-historical-block-limit minimum value is 512
minimalist-staker profile has it set to 128
check is done here
with trie-log-limit enabled = false (previous default), it doesn't do that check

can we lower the minimum value from 512 to 128 cc @non-fungible-nelson

[macfarla]

actually went the other way in the PR - changed minimalist-staker limit from 128 to 512

[macfarla]

(won't be a breaking change if we want to go the other way in the future)

[macfarla]

nope, changed again. minimum = 128 and default = 512

[non-fungible-nelson]

@siladu - any comments here? I know we had some interesting behaviors with minimums and defaults. What we would like to do is support a global default of 512, but a local default of 128 for the minimal staker profile.

[siladu]

@siladu - any comments here? I know we had some interesting behaviors with minimums and defaults. What we would like to do is support a global default of 512, but a local default of 128 for the minimal staker profile.

Discussed this with @macfarla.
I'm wondering what is the benefit of reducing from 512 -> 128?
In terms of storing trie logs, there's only about 60MB difference between 512 vs 128 so not worth the extra logic IMO.