Display configured target-gas-limit in startup logs

[siladu]

e.g. could look something like this:

####################################################################################################
#                                                                                                  #
# Besu version 25.7-develop-45f57d0                                                                #
#                                                                                                  #
# Configuration:                                                                                   #
# Network: Mainnet                                                                                 #
...
...
# target-gas-limit: 60M                                                                            #
...
####################################################################################################"

[gabrieledm]

I would like to work on this one

[jkktom]

I'm also interested in this issue, @gabrieledm hi, are you working on this? I'm open to collaboration too.

[gabrieledm]

Hi @jkktom, thanks for your availability but this is a really simple task and I think a person working on it is more than enough.

For @siladu, I added the required log.
This is the result starting besu with the command ./build/install/besu/bin/besu --target-gas-limit=21000

####################################################################################################
#                                                                                                  #
# Besu version 25.7-develop-bb35ae9                                                                #
#                                                                                                  #
# Configuration:                                                                                   #
# Network: Mainnet                                                                                 #
# Network Id: 1                                                                                    #
# Data storage: Bonsai                                                                             #
# Sync mode: Snap                                                                                  #
# Sync min peers: 5                                                                                #
# Engine APIs: ENGINE,ETH                                                                          #
# Engine port: 8551                                                                                #
# Engine JWT: /media/gabriele/Volume_1TB/Development/WorkspaceGitHub/besu/buil                     #
# d/install/besu/jwt.hex                                                                           #
# Using LAYERED transaction pool implementation                                                    #
# Using STACKED worldstate update mode                                                             #
# Parallel transaction processing enabled                                                          #
# Limit trie logs enabled: retention: 512; prune window: 5000                                      #
# Target Gas Limit: 21000                                                                          #
#                                                                                                  #
# Host:                                                                                            #
# Java: oracle_openjdk-java-21                                                                     #
# Maximum heap size: 7.76 GB                                                                       #
# OS: linux-x86_64                                                                                 #
# glibc: 2.39                                                                                      #
# Total memory: 31.03 GB                                                                           #
# CPU cores: 20                                                                                    #
#                                                                                                  #
# Plugin Registration Summary:                                                                     #
# No plugins have been registered.                                                                 #
# TOTAL = 0 of 0 plugins successfully registered.                                                  #
#                                                                                                  #
####################################################################################################

Anyway I noticed a strange behavior for the tests.
If I run all the tests under the app folder only one test fails: extraDataDefaultValueIsBesuVersion into org.hyperledger.besu.cli.options.MiningOptionsTest.

But if I run the same test alone or all the tests in org.hyperledger.besu.cli.options.MiningOptionsTest, the test extraDataDefaultValueIsBesuVersion passes.

Honestly I haven't investigate further but I guess this is not related to any of my updates so I think I can open a PR for this issue.

I will proceed in the next days.

[siladu]

Hi @gabrieledm thanks for picking this up.

The gas limit we use on mainnet currently is 45000000 (https://github.com/hyperledger/besu/blob/04756c4291167e05c9d1dd42cdb016a74b2d19f5/consensus/merge/src/main/java/org/hyperledger/besu/consensus/merge/blockcreation/MergeCoordinator.java#L84)

It would be great to make that more readable, e.g. 45M or even 45,000,000 would help.
If someone configured 21000 though, then 21000 or 21,000 would be better than 0.021M.

I've also noticed some test flakiness in MiningOptionsTest, I wouldn't worry about it for this PR, we will look into it separately. We have a label for tracking these issues too https://github.com/hyperledger/besu/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20label%3Aflake

If you have the code ready, please open a PR so we can comment on that directly :)

[siladu]

Hi @jkktom thanks for your interest, keep an eye out for good first issues and feel free to chat to us in LFDT discord #besu-contributors channel if you have any questions.

You're welcome to open a PR at any time.

[gabrieledm]

Hi @gabrieledm thanks for picking this up.

The gas limit we use on mainnet currently is 45000000 (

besu/consensus/merge/src/main/java/org/hyperledger/besu/consensus/merge/blockcreation/MergeCoordinator.java

Line 84 in 04756c4

private static final long DEFAULT_TARGET_GAS_LIMIT = 45_000_000L;
)
It would be great to make that more readable, e.g. 45M or even 45,000,000 would help. If someone configured 21000 though, then 21000 or 21,000 would be better than 0.021M.

I've also noticed some test flakiness in MiningOptionsTest, I wouldn't worry about it for this PR, we will look into it separately. We have a label for tracking these issues too https://github.com/hyperledger/besu/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20label%3Aflake

If you have the code ready, please open a PR so we can comment on that directly :)

Thanks @siladu.

I created a PR for this and opened issue #8999 for MiningOptionsTest strange behavior but I can't add the flake label to it.