fix: return error response for genesis block in debug_traceBlockByNumber#10133
Merged
macfarla merged 3 commits intobesu-eth:mainfrom Apr 1, 2026
Merged
Conversation
Contributor
Author
|
@macfarla please take a look thanku |
Genesis block (block 0) has no transactions to trace. Instead of returning null, return a JSON-RPC error matching the debug trace spec. Relates to besu-eth#10115 Signed-off-by: Vivek Singh Solanki <viveksolanki0509@gmail.com>
f7d5c68 to
726250d
Compare
Contributor
Author
|
@macfarla I’ve rebased the branch and pushed the to rerun the CI. The two failing checks were unrelated to this PR. Could you please approve the workflows? |
Contributor
Author
|
CI failures appear to be due to Maven Central returning 403s, unrelated to this change. Should resolve on re-run, the past two ci that failed before are now passing. |
macfarla
approved these changes
Apr 1, 2026
10 tasks
vivek-0509
added a commit
to vivek-0509/besu
that referenced
this pull request
Apr 2, 2026
…error response Updated DebugTraceTransactionIntegrationTest to expect JsonRpcErrorResponse instead of success with null for unknown transaction hash. Added changelog entry covering both debug_traceTransaction (besu-eth#10150) and debug_traceBlockByNumber (besu-eth#10133) error response changes. Refs: besu-eth#10115 Signed-off-by: Vivek Singh Solanki <viveksolanki0509@gmail.com>
vivek-0509
added a commit
to vivek-0509/besu
that referenced
this pull request
Apr 2, 2026
…error response Updated DebugTraceTransactionIntegrationTest to expect JsonRpcErrorResponse instead of success with null for unknown transaction hash. Added changelog entry covering both debug_traceTransaction (besu-eth#10150) and debug_traceBlockByNumber (besu-eth#10133) error response changes. Refs: besu-eth#10115 Signed-off-by: Vivek Singh Solanki <viveksolanki0509@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Genesis block (block 0) has no transactions to trace, it represents the initial chain state with no EVM execution. Previously, calling
debug_traceBlockByNumberwith block0x0returnednull. This change returns a proper JSON-RPC error response ({"code": -32000, "message": "genesis is not traceable"}) matching the debug trace spec.Changes:
GENESIS_BLOCK_NOT_TRACEABLEerror type toRpcErrorTypeDebugTraceBlockByNumber.resultByBlockNumber()Fixed Issue(s)
Relates to #10115 (Item 6)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests