Draft
Conversation
Signed-off-by: garyschulte <garyschulte@gmail.com>
…ill is introducing an additional commit of preimagestorage. subsequent commits should add preimage storage to the trielog transaction commit, eliminating the additional transaction commit. Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
commented
Apr 9, 2026
| BlockchainSetupUtil::mainnetProtocolContextProvider, | ||
| new EthScheduler(1, 1, 1, 1, new NoOpMetricsSystem()), | ||
| serviceManager); | ||
| new EthScheduler(1, 1, 1, 1, new NoOpMetricsSystem())); |
Contributor
Author
There was a problem hiding this comment.
this is unwanted refactor. we should keep the non-null service manager constructor
| final WorldStateArchive worldArchive = | ||
| storageFormat == DataStorageFormat.BONSAI | ||
| ? createBonsaiInMemoryWorldStateArchive(blockchain, serviceManager) | ||
| ? createBonsaiInMemoryWorldStateArchive(blockchain, null) |
| .filter(val -> val.size() == Address.SIZE) | ||
| .map(val -> Address.wrap(Bytes.wrap(val))); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
if getRawPreimage() just a test consideration, we should remove it. The interface should not expose implementation details like shared hash preimage pool across trie keys and accounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
fixes #7796
rebased/refactored preimage store PRs, see #7800 , #9553
What is still outstanding to come out of draft / be mergeable to main?
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests