Closed
Conversation
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
|
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…fleet-mode Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
besu/src/main/java/org/hyperledger/besu/services/SynchronizationServiceImpl.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
force-pushed
the
feature/fleet-mode
branch
4 times, most recently
from
e201183 to
7c1da83
Compare
Merged
garyschulte
reviewed
Dec 7, 2023
Comment on lines
+218
to
+221
| public void setMiningCoordinator(final MiningCoordinator miningCoordinator) { | ||
| this.miningCoordinator = miningCoordinator; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
why is this here? future use perhaps?
Contributor
Author
There was a problem hiding this comment.
seems to be useless I removed it
garyschulte
reviewed
Dec 7, 2023
| */ | ||
| public BesuConfigurationImpl(final Path dataPath, final Path storagePath) { | ||
| this.dataPath = dataPath; | ||
| public BesuConfigurationImpl(final Path storagePath, final Path dataPath) { |
Contributor
There was a problem hiding this comment.
switching the order of these params can lead to problems the compiler won't highlight. I see 6 usages of this constructor in the codebase, but none of them are changed in this pr...
Contributor
Author
There was a problem hiding this comment.
clearly seems to be dangerous and useless, I will revert that
garyschulte
force-pushed
the
feature/fleet-mode
branch
3 times, most recently
from
6043342 to
033e3c8
Compare
Signed-off-by: delehef <franklin.delehelle@odena.eu> Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
…he correct number of times (besu-eth#6259) * Test that the BlockAwareOperationTracer are invoked the correct number of times * Remove redundant calls to traceEndBlock Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/fleet-mode
branch
from
033e3c8 to
9ed1166
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/fleet-mode
branch
2 times, most recently
from
8b6aaf1 to
8880cfc
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/fleet-mode
branch
from
8880cfc to
1e091d6
Compare
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
|
|
||
| boolean setHead(final BlockHeader blockHeader, final BlockBody blockBody); | ||
|
|
||
| boolean setHeadUnsafe(BlockHeader blockHeader, BlockBody blockBody); |
Check notice
Code scanning / CodeQL
Useless parameter
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Contributor
|
Closing for #6641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Added necessary plugin services and some light modifications to implement a plugin solution for the fleet mode feature.
Add modification in order to have fleet mode
Fixed Issue(s)