Update OpenJDK latest Docker image to use Java 21#6189
Conversation
|
fab-10
changed the title
docker/openjdk-latest/Dockerfile
Outdated
|
|
||
| RUN apt-get update && \ | ||
| apt-get install --no-install-recommends -q --assume-yes openjdk-19-jre-headless=19* libjemalloc-dev=5.* && \ | ||
| apt-get install --no-install-recommends -q --assume-yes openjdk-21-jre-headless libjemalloc-dev adduser && \ |
There was a problem hiding this comment.
just curious, what triggered the need for adduser ?
There was a problem hiding this comment.
it is no more present in the base image
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
latest-java-21
branch
from
ae76a23 to
d5e12c3
Compare
docker/openjdk-latest/Dockerfile
Outdated
| @@ -1,9 +1,9 @@ | |||
|
|
|||
| FROM ubuntu:22.04 | |||
| FROM ubuntu:rolling | |||
There was a problem hiding this comment.
This will make reproducible builds difficult.
There was a problem hiding this comment.
what do you suggest to use for the base image?
There was a problem hiding this comment.
A fixed version such as what was specified, 22.04. Rolling and latest can change to latter distro versions whereas a major/minor will only contain security fixes. Perfect reproducability would involve the exact version. But I'm just going for "doesn't break when ubuntu upgrades"
There was a problem hiding this comment.
Fine for me, will set this to 23.10, was using rolling to automatically switch to a supported version, but that could actually breaks the build, like it happened now with the missing adduser
There was a problem hiding this comment.
I think i can accept that tradeoff for only this build profile.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
3 participants
PR description
Switched base image to
ubuntu:rolling, that follow any stable Ubuntu release, currently 23.10) since OpenJDK Java 21 is not available on latest LTS Ubuntu.