Skip to content

Refactor: Move rpcGasCap and rpcMaxLogsRange to apiConfiguration#6195

Merged
Gabriel-Trintinalia merged 8 commits intobesu-eth:mainfrom
Gabriel-Trintinalia:refactor-api-configuration
Nov 22, 2023
Merged

Refactor: Move rpcGasCap and rpcMaxLogsRange to apiConfiguration#6195
Gabriel-Trintinalia merged 8 commits intobesu-eth:mainfrom
Gabriel-Trintinalia:refactor-api-configuration

Conversation

@Gabriel-Trintinalia
Copy link
Copy Markdown
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented Nov 21, 2023

PR description

Move rpcGasCap and rpcMaxLogsRange to apiConfiguration

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@github-actions
Copy link
Copy Markdown

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review November 22, 2023 02:35
Copy link
Copy Markdown
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit with extra ()

…acceptance/dsl/node/ThreadBesuNodeRunner.java

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) November 22, 2023 03:05
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 31a57e0 into besu-eth:main Nov 22, 2023
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
…u-eth#6195)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
…u-eth#6195)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 4, 2023
…u-eth#6195)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima pushed a commit to gfukushima/besu that referenced this pull request Dec 15, 2023
…u-eth#6195)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants