create trie package for bonsai and forest#6300
Merged
matkt merged 4 commits intobesu-eth:mainfrom Dec 14, 2023
Merged
Conversation
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
|
macfarla
approved these changes
Dec 14, 2023
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
refactor looks good. There's an codeQL warning that is not related to this PR but maybe create a ticket for it
Non-synchronized override of synchronized method
Warning
Method 'addCachedLayer' overrides a synchronized method in but is not synchronized.
Contributor
There was a problem hiding this comment.
I realise this was not modified in this PR but the codeQL warning sounds like something we should look at -
Non-synchronized override of synchronized method
Warning
Method 'addCachedLayer' overrides a synchronized method in but is not synchronized.
Contributor
Author
There was a problem hiding this comment.
clearly maybe we need to create ticket for it. it's for reference tests so should be easy to fix
Contributor
Author
There was a problem hiding this comment.
@garyschulte do you know why the synchronized is remove for this method ?
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>
jflo
added a commit
that referenced
this pull request
Dec 19, 2023
* Increase scope of reference tests (#6287) Add new forks to transaction tests, add bad rlp to rlp ref tests. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: jflo <justin+github@florentine.us> * Add trace to web socket JSON/RPC responses (#6285) * Add trace to web socket JSON/RPC responses Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Don't throw runtime exception if we can't parse JSON for trace Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] Include Enode URL in error message if parsing exception (#6288) * include the actual Enode URL in the error message if IP can't be resolved --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * Execute the terminatedImmediately method only once (#6284) Signed-off-by: David Lutzardo <jdlutzardo@izertis.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * move forest class to a specific package (#6293) cleaning up the worldstate section, moving and renaming everything that is forest into a specific package in order to clarify the difference between Bonsai and Forest in the code. --------- Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * removed vintage junit dependency (#6296) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * updated cli and chainimport/export tests to junit 5 (#6281) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] CLI Subcommands migrate to junit 5 (#6282) * updated cli and chainimport/export tests to junit 5 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * subcommands and besucommand test to junit5 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * removed duplicate line Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * removed vintage junit dep Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] add genesis file name to config overview (#6297) * add genesis file name to config overview Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * create trie package for bonsai and forest (#6300) Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> * [MINOR] More cli tests to junit 5 (#6283) * more CLI and services tests to junit5 --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * Update Gradle plugins and replace unmaintained license plugin (#6275) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * Quick fix to avoid a tight loop when processing added blocks in txpool (#6309) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us> * uprev to version 23.10.3-RC4 Signed-off-by: jflo <justin+github@florentine.us> * mark deleted slot during clear storage step Signed-off-by: Karim Taam <karim.t2am@gmail.com> --------- Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: David Lutzardo <jdlutzardo@izertis.com> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: matkt <karim.t2am@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: David Lutzardo <jdlutzardo@izertis.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
A PR to place Bonsai and Forest in the same trie package. This PR is a preparation for the introduction of Verkle. This trie package will have Verkle in a next PR and we will add a common package so that the different trie substructures can share classes if needed.
Fixed Issue(s)